-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding code to print report dictionary from yaml block #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @devplayer55221
Can you please revert the changes in the config_client.py and test the changes?
Hi @Prateek-Thakare |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you directly use configprovider to access the config here? Having an util just for this is redundant. If any usecase arrives in future we can move this as an util
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Changes removed from config_utils.py and modified report_workflow to directly use ConfigProvider
setup/docker/docker-compose.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert these changes to original and do not commit any changes on this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the code, the changes are as expected. The if condition blocks in the arg_parse need to be generalised, which will be done in future commits.
Thanks @Prateek-Thakare |
Adding code to print report dictionary from yaml block
mantis report -o example_org