Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding code to print report dictionary from yaml block #61

Merged
merged 5 commits into from
Oct 23, 2024

Conversation

devplayer55221
Copy link
Contributor

  1. Adding report block to local.yaml
  2. Adding code for printing report block from local.yaml as dictionary with the command mantis report -o example_org

Copy link
Collaborator

@Prateek-Thakare Prateek-Thakare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @devplayer55221
Can you please revert the changes in the config_client.py and test the changes?

@devplayer55221
Copy link
Contributor Author

Hi @Prateek-Thakare
I reverted the changes to config_client.py.
Added report to the config_model.py.
It is working.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you directly use configprovider to access the config here? Having an util just for this is redundant. If any usecase arrives in future we can move this as an util

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Changes removed from config_utils.py and modified report_workflow to directly use ConfigProvider

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert these changes to original and do not commit any changes on this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Collaborator

@Prateek-Thakare Prateek-Thakare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code, the changes are as expected. The if condition blocks in the arg_parse need to be generalised, which will be done in future commits.

@Prateek-Thakare Prateek-Thakare merged commit f025ea9 into PhonePe:main Oct 23, 2024
@devplayer55221
Copy link
Contributor Author

Thanks @Prateek-Thakare

hiteshkumarthakur pushed a commit to hiteshkumarthakur/mantis that referenced this pull request Nov 28, 2024
Adding code to print report dictionary from yaml block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants