Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker Compose Command Usage and Cleanup Script - Issue #8 #9

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

ethanlacerenza
Copy link
Contributor

Fix Docker Compose Command and Cleanup Script

Description

This PR addresses an issue where the Docker Compose command was failing due to incorrect usage of the --quiet flag. Additionally, some cleanup and formatting improvements were made to enhance readability and maintainability.

Changes Made:

  • Changed docker compose to docker-compose to properly execute Docker Compose commands.
  • Removed unnecessary usage of the --quiet flag in the Docker Compose command.
  • Minor cleanup and formatting improvements for clarity and readability.

Checklist:

  • Verified that the script now executes without errors.

Additional Notes:

  • Please review the changes and verify that the script operates as expected.
  • Suggestions and feedback are welcome for further improvements.

Before the fix:

image
image

After the fix:

image

@0xbharath
Copy link
Collaborator

0xbharath commented Apr 8, 2024

Thanks for raising the PR. There are two commits in this PR. I have reviewed both of them.

Above 1st commit: The change from command docker-compose to sub-command docker compose seems necessary and I'll merge it.

About 2nd commit: The removal of --quiet will break the summary table. I'm also not able to reproduce the --quiet error using compose v2.20.3. Docker compose still supports --quiet https://docs.docker.com/reference/cli/docker/compose/ps/ . I'm trying to reproduce the error or change the command structure to not let the error occur. More info or help in reproducing this will be appreciated.

@0xbharath 0xbharath added the bug Something isn't working label Apr 8, 2024
@0xbharath 0xbharath self-assigned this Apr 8, 2024
@ethanlacerenza
Copy link
Contributor Author

@0xbharath
The error lies in the command order.

image

Correct order:

image

I'll amend my commit to adhere to the correct order.

@ethanlacerenza
Copy link
Contributor Author

Hi there! Please let me know if this commit resolves the issue with the --quiet option and the table schema.

If you need any further assistance, feel free to reach out. I'm currently using Mantis, and everything is working correctly on Ubuntu 22.04.

@0xbharath
Copy link
Collaborator

The changes look good now. Thanks for contributing. Will merge this.

@0xbharath 0xbharath merged commit 4106384 into PhonePe:main Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants