Fix for PHP 8.4 #227
Merged
Fix for PHP 8.4 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Deprecated: Gt\CssXPath\Translator::preg_match_collated(): Implicitly marking parameter $transform as nullable is deprecated, the explicit nullable type must be used instead in ./phpgt/cssxpath/src/Translator.php on line 279
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Jul 8, 2024
Sole fix needed so far seems to be related to https://wiki.php.net/rfc/deprecate-implicitly-nullable-types See also upstream PR PhpGt/CssXPath#227 We are also hitting was seems to be a PHP bug php/php-src#14873
Alkarex
added a commit
to FreshRSS/FreshRSS
that referenced
this pull request
Jul 9, 2024
* Initial support for PHP 8.4 Sole fix needed so far seems to be related to https://wiki.php.net/rfc/deprecate-implicitly-nullable-types See also upstream PR PhpGt/CssXPath#227 We are also hitting was seems to be a PHP bug php/php-src#14873 * Fix return type * Disable OPCache while waiting for PHP fix
|
Thank you @Alkarex |
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Jul 12, 2024
Includes PhpGt/CssXPath#227 Follow-up of PhpGt/CssXPath#227 for PHP 8.4 Requires PHP 8.0+ Full diff PhpGt/CssXPath@d99d35f...45f3ac1
Alkarex
added a commit
to FreshRSS/FreshRSS
that referenced
this pull request
Sep 6, 2024
Includes PhpGt/CssXPath#227 Follow-up of PhpGt/CssXPath#227 for PHP 8.4 Requires PHP 8.0+ Full diff PhpGt/CssXPath@d99d35f...45f3ac1
|
@g105b this pr is merged since quite long back, it seems new version of this package is not yet released. Can we expect this ? |
|
@glo71317 For information, this is how I include CssXPath in FreshRSS, without depending on a new release: |
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Jan 11, 2025
Alkarex
added a commit
to FreshRSS/FreshRSS
that referenced
this pull request
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wiki.php.net/rfc/deprecate-implicitly-nullable-types