-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support grafana #205
Conversation
Signed-off-by: lijie <[email protected]>
Potential problems:
Fixing suggestions:
|
A suggested fix is to provide additional documentation on how the Grafana package can be installed and used in the existing system. It would also be helpful to include any dependencies that are required for Grafana to function properly. Additionally, it would be useful to have more details on how the package is tested and verified to work as expected. |
Signed-off-by: wuhuizuo <[email protected]>
Review for Pull Request "feat: support grafana"SummaryThis pull request adds support for Grafana to the project's package.yaml.tmpl and build-package-artifacts.sh.tmpl files. Specifically, it adds a new router for Grafana with a new script for building Grafana artifacts in the build-package-artifacts.sh.tmpl file. Potential Problems
Fix Suggestions
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Also close #208