-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add target branch env var #209
Conversation
Signed-off-by: lijie <[email protected]>
There are no potential problems that can be identified from the diff as it is a simple addition of an environment variable. However, it is always a good practice to make sure that the new environment variable is properly documented and added to the documentation. Suggestions:
|
Potential problems that can be identified are:
Fixing suggestions:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Why:
fix build grafana error:
empty branch/tag info for tidb