Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: add tiflow-engine docker image" #220

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

wuhuizuo
Copy link
Contributor

Reverts #219

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind January 24, 2024 14:37
Copy link

ti-chi-bot bot commented Jan 24, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the pull request title and description, it looks like the changes aim to revert a previously added feature of adding a tiflow-engine docker image. The diff shows that the tiflow-engine container image has been removed from the packages.yaml.tmpl file.

However, without more context about why this feature was added and why it's being removed, it's difficult to determine whether this is the right decision. Therefore, it would be helpful to have more information about the reason for the revert.

Assuming that the revert is necessary, the changes look straightforward and do not introduce any new code. Therefore, the risk of new bugs is minimal.

As for suggestions, it would be helpful to provide more information about why this feature was added and then reverted. If there was a specific issue or problem with the tiflow-engine image, it would be useful to know what that was. Additionally, it's always a good idea to test and verify that the changes made don't have any unexpected consequences.

@ti-chi-bot ti-chi-bot bot added the size/XS label Jan 24, 2024
@wuhuizuo
Copy link
Contributor Author

I makes tiflow build failed

@wuhuizuo
Copy link
Contributor Author

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Jan 24, 2024
@jayl1e
Copy link
Contributor

jayl1e commented Jan 24, 2024

/lgtm

@ti-chi-bot ti-chi-bot bot merged commit fc53209 into main Jan 24, 2024
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the revert-219-feat/tiflow-docker branch January 24, 2024 14:40
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 24, 2024
Copy link

ti-chi-bot bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lijie0123, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jan 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-24 14:40:54.39237916 +0000 UTC m=+971695.956676861: ☑️ agreed by lijie0123.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants