Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packages): support build for ctl component #239

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Conversation

wuhuizuo
Copy link
Contributor

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot ti-chi-bot bot requested a review from jayl1e February 20, 2024 12:06
Copy link

ti-chi-bot bot commented Feb 20, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Review for GitHub Pull Request

Summary

This pull request is fixing a minor issue with a spelling mistake and a tag name not being correctly set. The spelling mistake has been corrected, and the tag name has been updated to exclude the profile name when the profile is "release".

Potential Problems

There is no potential problem with this pull request.

Fixing Suggestions

No fixing suggestion needed.

@ti-chi-bot ti-chi-bot bot requested a review from purelind February 20, 2024 12:06
@ti-chi-bot ti-chi-bot bot added the size/S label Feb 20, 2024
@wuhuizuo wuhuizuo changed the title fix(packages): do not add profile name in tag when profile is release feat(packages): support build for ctl component Feb 20, 2024
@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit 421c1ee into main Feb 20, 2024
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/ctl-pkg-build branch February 20, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant