Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dockerfiles/cd/builders/tikv): add builder image with devtoolset 10 #325

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

wuhuizuo
Copy link
Contributor

No description provided.

@ti-chi-bot ti-chi-bot bot requested a review from purelind June 12, 2024 03:24
Copy link

ti-chi-bot bot commented Jun 12, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

From the pull request, it appears that the change adds a new builder image with devtoolset 10. This involves updating the relevant files, including the pull-cd-builder-images.yaml and release-cd-builder-images.yaml files, as well as the skaffold.yaml file.

One potential problem is the possibility of introducing errors or bugs in the new image. It would be helpful to have more information about the testing and QA process used for this change. Additionally, it is unclear if this change will impact any other parts of the codebase or if it is isolated to the builder image.

Suggestions for fixing would be to provide more details about the testing and QA process, as well as any impact analysis. It may also be helpful to have a peer review of the code change before merging it into the codebase.

@ti-chi-bot ti-chi-bot bot added the size/S label Jun 12, 2024
@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 12, 2024
@wuhuizuo wuhuizuo merged commit 64610d1 into main Jun 12, 2024
23 of 25 checks passed
@wuhuizuo wuhuizuo deleted the feature/tikv-builder-devtoolset-10 branch June 12, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant