-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dockerfiles/cd/builders): add go-1.23 and tiflash in to build workflows #394
Conversation
…rkflows Signed-off-by: wuhuizuo <[email protected]>
Based on the pull request title and description, it seems that the changes add support for two new versions, go-1.23 and tiflash, in the build workflows. The changes are mainly in the pull-cd-builder-images.yaml and release-cd-builder-images.yaml workflows, as well as in the skaffold.yaml file in the dockerfiles/cd/builders directory. Potential problems that I can identify include:
Here are some suggestions for fixing the potential problems:
|
/approve |
/approve |
/hold |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Signed-off-by: wuhuizuo [email protected]