Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(packages): delivery experiment profile images #404

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Sep 6, 2024

They are builded with new builder container.

Signed-off-by: wuhuizuo [email protected]

They are builded with new builder container.

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot requested a review from purelind September 6, 2024 03:12
Copy link

ti-chi-bot bot commented Sep 6, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the changes in the pull request, it seems like the author has added new regex patterns for tags in the community and enterprise branches, and also removed some deprecated code. The author also mentions that new images were built using a new builder container.

There are no significant issues with the changes in the pull request. However, I would suggest the following changes:

  1. The author should provide more details about the new builder container used for building the images.
  2. The author should add a detailed commit message describing the changes made in the pull request.
  3. It might be helpful to add some comments to the code changes explaining the purpose and use of the new regex patterns.

Overall, the changes in the pull request seem fine, and I would approve it after the above-mentioned suggestions are implemented.

@ti-chi-bot ti-chi-bot bot added the size/M label Sep 6, 2024
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Sep 6, 2024

/approve

Copy link

ti-chi-bot bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 6, 2024
@ti-chi-bot ti-chi-bot bot merged commit be3268b into main Sep 6, 2024
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the build/add-develiry-for-expirement-profile branch September 6, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant