Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packages): bump tiup-ctl version to v1.16.0 for ctl package #412

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

wuhuizuo
Copy link
Contributor

Starts from v8.4.0

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot ti-chi-bot bot requested a review from purelind September 11, 2024 13:00
Copy link

ti-chi-bot bot commented Sep 11, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and description, the key change in this PR is the bumping of the tiup-ctl version from v1.8.1 to v1.16.0 in the packages.yaml.tmpl file. This change updates the download URL of the tiup-ctl binary.

There are no potential problems identified from the diff. However, it's always good to check if the new version of tiup-ctl is compatible with other dependencies in the project.

As for fixing suggestions, it would be helpful to include a brief explanation of why the tiup-ctl version was updated. Additionally, it would be beneficial to add a changelog entry to the PR description to document this change.

@ti-chi-bot ti-chi-bot bot added the size/XS label Sep 11, 2024
Copy link

ti-chi-bot bot commented Sep 12, 2024

@xhebox: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor Author

/approve

It's approved by component owner and PM.

Copy link

ti-chi-bot bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit ece5a75 into main Sep 12, 2024
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/bump-tiup-ctl branch September 12, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants