feat(dockerfiles/cd/builders): add other golang 1.23 builder images

[wuhuizuo]

Signed-off-by: wuhuizuo [email protected]

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Key Changes:

• The PR adds three new Golang builder images: go-1.23, go-1.22, and go-1.21.
• The PR deletes the Dockerfile for tiflash.
• The PR upgrades the base image in the Dockerfile for tikv.

Potential Problems:

• The description of the PR is too brief. It would be helpful to have more context on why these changes were made.
• The Dockerfile for tiflash is being deleted, but there is no explanation as to why. Was it no longer needed, or was it replaced with a new Dockerfile?
• The Dockerfile for tikv is upgrading the base image from Rocky Linux 9.3.20231119 to Rocky Linux 9.4.20240523. While this upgrade may be necessary, it could introduce new compatibility issues.

Fixing Suggestions:

• Ask the contributor to provide more context in the PR description, especially regarding the deletion of the Dockerfile for tiflash.
• Confirm with the contributor if the upgrade to the Rocky Linux base image is necessary and if they have tested it to ensure there are no compatibility issues.
• If the upgrade is necessary, suggest that the Dockerfile for tikv be thoroughly tested before merging the PR to avoid any potential issues.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the changes added new GoLang builder images to the dockerfiles/cd/builders directory.

The changes also removed the dockerfiles-multi-stages/tiflash/Dockerfile file.

There are also changes to the dockerfiles/cd/builders/skaffold.yaml and dockerfiles/cd/builders/tikv/fips.Dockerfile files, which seem to add new GoLang versions and update the base image for the Tikv builder.

There are no major issues with the changes. However, there are some minor issues and suggestions:

• The PR description is too short and does not provide enough context. It would be helpful if the contributor could provide more details on why these changes were made and how they impact the project.
• The removed dockerfiles-multi-stages/tiflash/Dockerfile file should be properly deprecated and documented in the project's documentation so that users are aware of the change.
• The new GoLang versions added in dockerfiles/cd/builders/skaffold.yaml should be properly tested to ensure that they work as expected and do not cause any issues.
• The base image for the Tikv builder (quay.io/rockylinux/rockylinux:9.4.20240523) should be properly tested to ensure that it works as expected and does not cause any issues.

[wuhuizuo]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wuhuizuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

This pull request adds other golang 1.23 builder images to the Dockerfiles. It updates the Skaffold version to 2.13.2 for all CD builders, and also adds tag policies for the new golang images.

There are no potential problems that I can see in this pull request.

Some suggestions for fixing are:

• Use the latest version of Rocky Linux in the Dockerfile for tikv/fips from the Quay.io registry, instead of a specific version.
• Consider adding more details in the Pull Request description about the reasons for adding the new golang images, and why they are needed.