feat(packages): switch to new builder for release profile

[wuhuizuo]

Signed-off-by: wuhuizuo [email protected]

TODOs:

• how to deal the tidb-tools repo which is released on master branch.
• how to deal the tidb-ctl repo which is released on master branch.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

The pull request titled "feat(packages): switch to new builder for release profile" primarily involves changes in the builder configurations of multiple components within the packages.yaml.tmpl file.

Key changes include:

1. The experiment profile is being removed from multiple components.
2. The builder image used is being updated for specific semver constraints.
3. Several script blocks under experiment profile have been removed.
4. The version constraint for several builders has been updated to include an upper bound (< 8.4.0-0).

Potential problems:

1. The removal of the experiment profile might impact the components that rely on this profile for specific behaviors.
2. The new builder image might not be fully compatible with all the components, or there might be unforeseen issues with the new image.
3. The script blocks removed from the experiment profile might have been crucial for some steps in the build process.

Fixing suggestions:

1. Before merging, it's necessary to ensure that no existing processes or components rely on the experiment profile.
2. Thorough testing should be performed after switching to the new builder image to ensure all components are working correctly.
3. It would be good to understand why the script blocks under experiment profile are removed and what implications this might have. If these scripts were necessary, an alternative solution should be provided.
4. Finally, the version constraint changes should be reviewed to ensure they align with the versioning strategy of the project.

Please consider these points and make necessary changes before proceeding with the merge.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

The title of the pull request (PR) suggests that the main change is the switch to a new builder for the release profile.

Key Changes:

1. The experiment profile has been removed from various components and only the release profile is retained. This is done across multiple components like ctl, ng-monitoring, pd, tidb, tidb-dashboard, tiflash, tiflow, tikv, and tiproxy.

2. The builder version has been updated for the release profile. Specifically, for versions ">= 8.4.0-0", a newer builder image is used (ghcr.io/pingcap-qe/cd/builders/*:v20240901-15-gdc1ad6e-go1.23), and for versions between ">= 7.4.0-0, < 8.4.0-0", an older builder image is used (ghcr.io/pingcap-qe/cd/builders/*:v20240325-91-g4bdc4c6-go1.21).

3. A number of script sections related to the experiment profile have been removed.

Potential Problems:

1. This PR includes major changes that may affect the build process of different components. If the experiment profile was being used in certain environments or for certain use cases, those will be affected.

2. The PR description includes two TODOs regarding how to deal with the tidb-tools and tidb-ctl repos, which are released on the master branch. These may be potential issues that need to be addressed.

Fixing Suggestions:

1. Ensure that the removal of the experiment profile does not affect any environments or use cases. If necessary, provide an alternate approach for those use cases.

2. Address the TODOs in the PR description. If the tidb-tools and tidb-ctl repos are dependent on the experiment profile, then a strategy needs to be devised for them.

3. Run thorough testing to ensure the new builders work as expected for the release profile.

4. It would be beneficial to provide more context or reasoning in the PR description about why these changes are being made, to help reviewers understand the motivation behind them.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

This pull request is about switching to a new builder for the release profile.

Key Changes:

1. In the ci.sh script, blocks of code for the experiment profile are commented out. It seems these blocks of code are no longer needed.
2. In the packages.yaml.tmpl, the profile experiment is being removed from multiple sections. It seems the experiment profile is no longer supported.
3. The builder version of multiple components has been updated. The new builder version is used when the release version is greater than or equal to 8.4.0-0.
4. The experiment steps are removed from several sections in the packages.yaml.tmpl.

Potential Problems:

1. If the experiment profile is still used in some scenarios, removing it might cause problems.
2. The new builder is used when the release version is greater than or equal to 8.4.0-0. If there are versions less than 8.4.0-0 that require this new builder, they won't be able to use it.
3. In the TODOs, the author mentions how to handle the tidb-tools and tidb-ctl repos which are released on the master branch. It is unclear how these changes will affect these repos.

Fixing Suggestions:

1. If the experiment profile is still in use, consider making it optional or creating a separate script for it.
2. For the new builder version, you may need to test it on all versions to ensure compatibility.
3. For the tidb-tools and tidb-ctl repos, you might need to discuss with the team on the best approach to handle them. If they are tightly coupled with the main repo, consider integrating their release process into the main repo.

[wuhuizuo]

I have already done a preliminary review for you, and I hope to help you do a better job.

This pull request is about switching to a new builder for the release profile.

Key Changes:

1. In the ci.sh script, blocks of code for the experiment profile are commented out. It seems these blocks of code are no longer needed.
2. In the packages.yaml.tmpl, the profile experiment is being removed from multiple sections. It seems the experiment profile is no longer supported.
3. The builder version of multiple components has been updated. The new builder version is used when the release version is greater than or equal to 8.4.0-0.
4. The experiment steps are removed from several sections in the packages.yaml.tmpl.

Potential Problems:

1. If the experiment profile is still used in some scenarios, removing it might cause problems.
2. The new builder is used when the release version is greater than or equal to 8.4.0-0. If there are versions less than 8.4.0-0 that require this new builder, they won't be able to use it.
3. In the TODOs, the author mentions how to handle the tidb-tools and tidb-ctl repos which are released on the master branch. It is unclear how these changes will affect these repos.

Fixing Suggestions:

1. If the experiment profile is still in use, consider making it optional or creating a separate script for it.
2. For the new builder version, you may need to test it on all versions to ensure compatibility.
3. For the tidb-tools and tidb-ctl repos, you might need to discuss with the team on the best approach to handle them. If they are tightly coupled with the main repo, consider integrating their release process into the main repo.

/hold

it must be merged after the change of ee-ops repo:

• Revert "feat(apps/prod/tekton/configs/triggers): add triggers to build artifacts with experiment profile (#1245)" ee-ops#1279

[wuhuizuo]

/approve

[wuhuizuo]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wuhuizuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wuhuizuo]

/unhold