Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pingcap/community): fix sync owners deno script #2382

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Aug 25, 2023

Fixes #2377
Ref octokit/oauth-app.js#424

Also make it faster by reducing needless sleep.

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind August 25, 2023 10:40
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 25, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Summary

The pull request fixes an issue and updates the update-prow-owners.ts file in the scripts/pingcap/community directory. Specifically, the pull request updates the Octokit import from https://esm.sh/[email protected] to npm:/[email protected] and adds a filter to Array.from(owners) which filters out repositories that are not in the same organization as the target repository or are not the target repository.

Potential Problems

There are no potential problems with this pull request.

Fixing Suggestions

There are no fixing suggestions needed for this pull request.

@ti-chi-bot ti-chi-bot bot added the size/S label Aug 25, 2023
@wuhuizuo wuhuizuo force-pushed the wuhuizuo/issue2377 branch from 9629e16 to e5fee5b Compare August 25, 2023 10:44
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 25, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Summary:
This pull request fixes an issue related to updating the OWNERS file in repositories owned by PingCAP. The changes include updating the version of the Octokit dependency and modifying the code logic to skip repositories that are not owned by PingCAP or that do not match a specified repository name.

Potential problems:
It is difficult to identify potential problems without more context on the specific issue that is being fixed and how the changes in this pull request address that issue.

Fixing suggestions:
If the changes in this pull request have been tested and are confirmed to fix the issue, then they can be merged. However, if there are any potential problems or if the changes have not been thoroughly tested, then it may be necessary to request additional information or testing before merging.

@wuhuizuo wuhuizuo added the lgtm label Aug 25, 2023
@wuhuizuo
Copy link
Collaborator Author

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 25, 2023

@wuhuizuo: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the approved label Aug 25, 2023
@wuhuizuo
Copy link
Collaborator Author

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 9c24aa0 into main Aug 25, 2023
@ti-chi-bot ti-chi-bot bot deleted the wuhuizuo/issue2377 branch August 25, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

pingcap/community: sync owners jobs unstable
1 participant