Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(apps/gcp/prow/release): bump hook image to v20230719-dcd9b36" #664

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Aug 7, 2023

Reverts #646

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 7, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the provided information, it seems that this pull request is reverting a previous commit. The change that is being reverted is related to the bumping of a hook image version in the release.yaml file for the Prow application.

There are no potential problems identified in this pull request since it is only undoing a previous change. However, it is important to check if the version being reverted is causing any issues and if there is a need to bump the version to a newer one.

Regarding fixing suggestions, it depends on the reason why the previous bump was made and if there is a need to bump the version again. If there is no need to bump the version again, this pull request is enough. However, if there is a need to bump the version again, a new pull request should be created with the new version.

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind August 7, 2023 12:58
@ti-chi-bot ti-chi-bot bot added the size/XS label Aug 7, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 7, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
From the pull request and the diff, it seems that the change is to revert a previous commit, which bumped the hook image to v20230719-dcd9b36. The change is to revert to the previous version 0.9.7.

There isn't any potential problem found in this pull request since it is to revert to the previous version. However, it's unclear from the pull request description why the revert is necessary. It would be better to add some context or explanation about why the previous commit needs to be reverted.

In terms of fixing suggestions, if there is a specific reason to revert the previous commit, it might be better to add it to the pull request description to provide more context for future reviews. Additionally, if there are any changes required to make this revert work properly, it would be helpful to document them explicitly in the pull request description.

@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Aug 7, 2023

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 7, 2023
@wuhuizuo wuhuizuo merged commit 9f2e43e into main Aug 7, 2023
@wuhuizuo wuhuizuo deleted the revert-646-feature/upgrade-dev-cluster-prow-hook branch August 7, 2023 13:01
wuhuizuo added a commit that referenced this pull request Aug 7, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant