-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust error format updates and IDE support #229
Comments
This does indeed impact VisualRust, also compare #113. I might be able to work on porting the error recognition to use the JSON mode, once the PR has landed. In order to support previous |
I have already written some code for json error in https://github.com/Vbif/VisualRust/tree/json_error_format |
@Vbif: This looks quite good, thanks! I think that using JSON errors shouldn't be a build option, though. Instead, VisualRust should transparently choose which error format is best, based on the version of rustc. It should never use @vosen: What do you think? |
@Boddlnagg remove unstable is easy. How can i determine rustc version? First run rustc with --version every build? |
@Vbif That is a very good question, and I don't have a good idea yet. Maybe it's possible to run |
Great to see some progress here! Friendly reminder - I'm going to each plugin and letting them know we're 17 days away from Rust 1.12 being released. This is the first release that uses the new error format (and removes support for the old format). It also has the standardized JSON errors. |
@jonathandturner Thanks for the reminder! We're going to be able to push this PR through the finish line until the release of 1.12, but I can't do a VisualRust release. I think only @vosen (this project's official maintainer) can do that, and he hasn't responded in the last weeks. |
#230 has been merged. |
I'm not sure if this will impact you, but I wanted to mention that we're currently talking about updating the Rust error format. For plugins using a regex style parse of the errors, this will likely have some impact.
If this PR is accepted, it will only initially impact the nightly builds. There are some weeks between the PR going it and a stable release including the new format. We'd like to use that time to make the transition as easy as possible.
As part of the PR, we're also enabling a supported JSON mode which IDE plugins can optionally use. It has the same information as the error text, but in a more structured way.
Please feel free to jump in on the PR thread and let us know if this impacts your plugin.
The text was updated successfully, but these errors were encountered: