Json error format

[Vbif]

No description provided.

[Boddlnagg]

Does this mean that the test will fail when the system language is not Russian? That would be bad. Can you try to make this locale independent?

[Vbif]

These test just check basic mapping between JSON and RustcMessageJson class. So it is not depend on language, but I definitely need translate error message

[Boddlnagg]

Thanks! I added some comments inline. Apart from that, this looks great :)

@vosen: Are you still maintaining this project? Do you also want to have a look? And why is AppVeyor not set up to test PRs also?

[Boddlnagg]

I just tested this and found a few more problems:

• The spans are incorrect: When you call LogError/LogWarning, you should use column_start/column_end instead of byte_start/byte_end for the columns.
• The error aborting due to previous error should not be forwarded (it has no span and no code)
• I think you have to add Newtonsoft.Json.dll as a component to the installer next to VisualRust.Build.dll. This is in VisualRust.Setup\VisualRust.wxs.

Besides that it seems to work 👍

[Vbif]

I have a problem with building setup package.

Severity    Code    Description Project File    Line    Suppression State
Error       The "ResolveWixReferences" task could not be loaded from the assembly \WixTasks.dll. Could not load file or assembly 'file:///C:\WixTasks.dll' or one of its dependencies. Не удается найти указанный файл. Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask.    VisualRust.Setup    C:\Program Files (x86)\MSBuild\Microsoft\WiX\v3.x\wix2010.targets   735 

[Boddlnagg]

@Vbif What version of WiX do you have installed? It works here with WiX 3.10.3

[Vbif]

v3.10.3.2904

[Boddlnagg]

Mine is v3.10.3.3007 .... and it looks like this issue was actually fixed there.

[Boddlnagg]

Will you be able to finish this? Otherwise I'm going to do it.
One more thing: You're checking for a version ≥ 1.11, but --error-format=json is only stabilized in 1.12, so you should change the version check to check for ≥ 1.12.

[Boddlnagg]

Thanks!

[vosen]

@Boddlnagg
yes, still interested in maintaining VR, just didn't have any free time lately. Conversely, are you? If so add youself to the README.
I disable AppVeyor on PR, because I've jave been commiting faster than AppVeyor could test my changes (It could take an hour to have a run) and with NCrunch my master-breaking changes were mostly isolated to WiX (which AppVeyor didn't catch anyway) so I settled on tests after merge.

[Boddlnagg]

@vosen: I don't really have enough time to take over maintenance, either.
As far as CI tests for PRs are concerned: That sounds reasonable. It still would be useful to have them sometimes (like, on demand), but that's probably not possible?

[vosen]

Ill look into it