reserved identifier violation

[elfring]

I would like to point out that identifiers like "_DrawTargetPerContextMap" and "_HasKind" do eventually not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

[amooty]

Filed as internal issue #135158.

[c64kernal]

Thanks for pointing this out, you're completely right of course. Our coding conventions come from an old code base that is quite large. We'd like to eventually move away from this one, but unfortunately it will take us some time. Thanks again for reporting!

[elfring]

Do you care still for further update candidates?

• https://github.com/PixarAnimationStudios/USD/blob/4a3f61e50fd862bfaa57b9a06b5f3d3c05c3bb09/pxr/base/lib/tf/pyObjWrapper.cpp#L49
• https://github.com/PixarAnimationStudios/USD/blob/4a3f61e50fd862bfaa57b9a06b5f3d3c05c3bb09/pxr/base/lib/tf/mallocTag.cpp#L782
• https://github.com/PixarAnimationStudios/USD/blob/4a3f61e50fd862bfaa57b9a06b5f3d3c05c3bb09/pxr/base/lib/work/testenv/testWorkDetachedTask.cpp#L35