make default value for readAnimData controlled by env. var #164
Conversation
|
Hi Paul,
0.7.3 makes readAnimData true by default. Given that, do we need this?
…--SpiffiPhone
On Feb 13, 2017, at 6:26 PM, Paul Molodowitch ***@***.***> wrote:
Description of Change(s)
Adds an environment var, $PIXMAYA_READ_ANIM_BY_DEFAULT, for controlling the default setting for readAnimData on import.
Included Commit(s)
df08435
Fixes Issue(s)
#145
You can view, comment on, or merge this pull request online at:
#164
Commit Summary
make default value for readAnimData controlled by env. var
File Changes
M third_party/maya/lib/usdMaya/JobArgs.cpp (8)
M third_party/maya/lib/usdMaya/referenceAssembly.cpp (3)
M third_party/maya/lib/usdMaya/usdTranslatorImport.cpp (11)
M third_party/maya/lib/usdMaya/usdTranslatorImport.h (6)
Patch Links:
https://github.com/PixarAnimationStudios/USD/pull/164.patch
https://github.com/PixarAnimationStudios/USD/pull/164.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
It does? It's still false in JobArgs (https://github.com/PixarAnimationStudios/USD/blob/master/third_party/maya/lib/usdMaya/JobArgs.cpp#L70), and in usdTranslatorImport (https://github.com/PixarAnimationStudios/USD/blob/master/third_party/maya/lib/usdMaya/usdTranslatorImport.h#L46). And I tested the behavior on this commit, which I believe comes off the dev branch that was merged for 7.3, and it still defaulted to off. However - if the plan is to make it true by default, then no, we don't need this... |
|
My mistake, twice over.
Here's the description:
--spiff |
|
Hmm - if it doesn't affect the scripting command, then the PR would still
be handy for us.
…On Tue, Feb 14, 2017 at 9:00 AM F. Sebastian (spiff) Grassia < ***@***.***> wrote:
My mistake, twice over.
1. The change I was thinking of went in just after we cut 0.7.3, and
it hasn't pushed out to github yet.
2. It only affects the import UI default.
Here's the description:
Make USD import UI read anim data by default
- This only affects the translator's default UI options
- This does not change the usdExport scripting command, which assumes
readAnimData=false by default unless the flag is explicitly set to true
--spiff
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#164 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEYeAOEzPRY55s3TFCooVQqcBWNq6S1ks5rcd2zgaJpZM4L_-vd>
.
|
Conflicts: third_party/maya/lib/usdMaya/usdTranslatorImport.h
|
@spiff, what do you think about forgoing the environment variable and just changing the default at the command level? It's a breaking change, but now's the time to make those kinds of choices. |
|
@chadrik - sorry for the delay. We discussed and do support changing the default to true at all levels. Thanks! |
|
Should I modify this pull request to just set the default at all levels? Or did you mean that was something you were going to do on your end? |
|
(and sorry for the close / reopen spam, that was something suggested by github support deal with the fact that github though the travis-ci build hadn't finished, while travis-ci said it had...) |
|
Hi Paul,
Go ahead and change all the defaults, please.
…--SpiffiPhone
On Mar 8, 2017, at 5:29 PM, Paul Molodowitch ***@***.***> wrote:
(and sorry for the close / reopen spam, that was something suggested by github support deal with the fact that github though the travis-ci build hadn't finished, while travis-ci said it had...)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Closing in favor of #174, which just defaults to true on all levels, with no env var |
…s#164) Implement Patterned polyline
Description of Change(s)
Adds an environment var, $PIXMAYA_READ_ANIM_BY_DEFAULT, for controlling the default setting for readAnimData on import.
Included Commit(s)
Fixes Issue(s)