Remove unnecessary null pointer check from meshTopology.cpp #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Geertiebear, thank you for your contribution and apologies for not getting back to you in a timely manner. The change you suggested was made recently during some code reorganization in commit 01769ba: https://github.com/PixarAnimationStudios/USD/blob/dev/pxr/imaging/lib/hdSt/meshTopology.cpp#L79 So, I'm closing out this pull request. Thanks again! |
asluk
pushed a commit
to NVIDIAGameWorks/USD
that referenced
this pull request
Apr 4, 2020
* Added Python usd_diff wrapper DLL(.pyd) and tests
* Added python wrapper to work with memStorage + memStorage.h & .cpp are created in USD
* USD TexFileFormat read using ArchFile (for memStorage)
* Omniverse USD plugin experiment
* Added file system impl. (to abstract memStorage) in USD
* MemStorage reset on file write added
* Experimental Omniverse USD plugin
* Changed folder structure (work in progress)
* Clean-up & fixes
* Fixed crash at the end of test_plugin.py
* Changed timestamp to VtValue(string)
* Plugin splitted to API & Impl.
* TLS for WriteToFileInfo in Plugin + CreateMemStorageRW method in plugin python wrapper
* Added mutex to make PluginImpl::_memStorageCache thread-safe
* Added cache for VtValue-s in CreateUSDdiff
* Plugin::UpdateWhole() & PluginCallbacks::ProcessNew() added
* Added PluginFetchBuilder to apply deltas in PluginCallbacks::Fetch
* MemFixedStorage & MemGrowingStorage combined into MemUniversalStorage
* Added Plugin.Reset() to clear memStorageCache
* Plugin clean-up
* Added error messages for PluginImpl::Apply{Text}Delta
* Cleanup error & debug messages in omni_plugin
* test_plugin.py cleanup
* Forget to fix plugInfo.json
* Fix for Linux build
* Fixed test_omni_plugin DEBUG build & clean-up test_plugin.py (test data moved to test_data)
* !server_data! -> TestStage in test_omni_plugin.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an issue which was brought up by issue #6 .