Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiverse support #63

Closed
wants to merge 1 commit into from
Closed

multiverse support #63

wants to merge 1 commit into from

Conversation

asluk
Copy link
Collaborator

@asluk asluk commented Sep 22, 2016

This is just to get the change to be reviewed by the Pixar folks, so they can see the actual code changes involved to get Multiverse support within the usdAbc plugin, as a CMake option. We've also discussed forking usdAbc with multiverse into its own standalone repo, to serve as a template for other developers writing SdfFileFormat plugins without needing to build the whole USD tree (e.g., on top of a brew install for USD on OSX, when that is available).

@spiffmon
Copy link
Member

Aaron, would you like to modify your change to account for just-filed
#70

Not sure what the right fix will be - guess it depends on whether the
multiverse fork follows suit with the 1.5.8 release?

On 09/21/2016 11:30 PM, asluk wrote:

This is just to get the change to be reviewed by the Pixar folks, so they
can see the actual code changes involved to get Multiverse support within
the usdAbc plugin, as a CMake option. We've also discussed forking usdAbc
with multiverse into its own standalone repo, to serve as a template for
other developers writing SdfFileFormat plugins without needing to build the
whole USD tree (e.g., on top of a brew install for USD on OSX, when that is
available).

    You can view, comment on, or merge this pull request online at:

#63

    Commit Summary

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#63, or mute the thread
https://github.com/notifications/unsubscribe-auth/AF7qaK-nH3nUHCtwQQZwlFXsP5adJea8ks5qsiBrgaJpZM4KDkNv.

@asluk
Copy link
Collaborator Author

asluk commented Sep 30, 2016

Yes, I can look at fixing that in a separate branch and then pulling it in.

As far as I can tell, the single-library Alembic was introduced in 1.6.0 -
alembic/alembic@834eca6

so I was thinking of using a version check to determine whether to look for
the single library or not, but I'm not sure if the same is true of the
Windows build for Alembic.

On Fri, Sep 30, 2016 at 8:24 PM, F. Sebastian (spiff) Grassia <
[email protected]> wrote:

Aaron, would you like to modify your change to account for just-filed
#70

Not sure what the right fix will be - guess it depends on whether the
multiverse fork follows suit with the 1.5.8 release?

On 09/21/2016 11:30 PM, asluk wrote:

This is just to get the change to be reviewed by the Pixar folks, so
they
can see the actual code changes involved to get Multiverse support
within
the usdAbc plugin, as a CMake option. We've also discussed forking
usdAbc
with multiverse into its own standalone repo, to serve as a template for
other developers writing SdfFileFormat plugins without needing to build
the
whole USD tree (e.g., on top of a brew install for USD on OSX, when that
is
available).

You can view, comment on, or merge this pull request online at:

#63

Commit Summary

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#63, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AF7qaK-
nH3nUHCtwQQZwlFXsP5adJea8ks5qsiBrgaJpZM4KDkNv>.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#63 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB_7ZtYzOZDgudAyy5fMgXFoG11c1GUGks5qvVPWgaJpZM4KDkNv
.

@asluk
Copy link
Collaborator Author

asluk commented Oct 1, 2016

@spiffmon - multiverse is currently forked from an earlier version of alembic that does not produce the single library. I went ahead and added USD build support for the single alembic library in issue #70 , but that is independent of this change. For multiverse, there's one more cleanup I want to add though (the boost_filesystem dependency that should be multiverse-specific). Thanks!

@spiffmon
Copy link
Member

spiffmon commented Oct 1, 2016

Thanks, Aaron - I was wondering about that dependency and why it was necessary... Can they not push it out of the header file, I wonder?

--SpiffiPhone

On Oct 1, 2016, at 3:08 PM, asluk [email protected] wrote:

@spiffmon - multiverse is currently forked from an earlier version of alembic that does not produce the single library. I went ahead and added USD build support for the single alembic library in issue #70 , but that is independent of this change. For multiverse, there's one more cleanup I want to add though (the boost_filesystem dependency that should be multiverse-specific). Thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@asluk
Copy link
Collaborator Author

asluk commented Oct 1, 2016

Should be fixed now-- only multiverse-enabled builds will bring in boost_filesystem.

@pberto
Copy link

pberto commented Oct 2, 2016

Thanks, Aaron - I was wondering about that dependency and why it was necessary... Can they not push it out of the header file, I wonder?

@spiffmon I sent you an e-mail mentioniong, along other things, that we need it to maintain the paths for the objects in the git repo of the multiverse abc files. Also we are now close to releasing 1.6.0+ (sinlgle lib) support, will be pushed soon (@panta). And big thanks to @asluk for the work.

@pberto
Copy link

pberto commented Oct 7, 2016

@asluk FYI we have updated Multiverse to Alembic API 1.6.1 just now.

@asluk
Copy link
Collaborator Author

asluk commented Oct 7, 2016

Thanks for the heads-up, @pberto . I tested with the panta/alembic-1.6.1-port branch and merged in my changes from my dev_abc_1_6_support into my dev_multiverse_support branch.

@asluk asluk force-pushed the dev_multiverse_support branch 3 times, most recently from aaf8f7f to 33080b3 Compare January 5, 2017 23:01
@asluk asluk force-pushed the dev_multiverse_support branch from 33080b3 to b79aa05 Compare January 5, 2017 23:03
@pberto
Copy link

pberto commented Jan 7, 2017

@asluk Alembic 1.7 port is also available now, branch: panta/alembic-1.7.0-port -- let us know.

@asluk
Copy link
Collaborator Author

asluk commented Jan 11, 2017

@pberto - I've verified that pulling #146 into this branch works with panta/alembic-1.7.0-port , and have made a separate pull request for the abc 1.7 fix as requested by Pixar folks. Cheers!

@pberto
Copy link

pberto commented Jan 12, 2017

@asluk Awesome! Beers are on me. Cheers!

pixar-oss pushed a commit that referenced this pull request Mar 13, 2017
@asluk @pixar-oss
[cmake, usdAbc] initial pass at Multiverse support.
f56da81 
[sunyab: Require dynamic linking of multiverse libs for now
         so that USD does not need to directly link against
         multiverse's dependencies]

Closes #63
pixar-oss added a commit that referenced this pull request Mar 13, 2017
@pixar-oss
Merge pull request #63 (with modifications)
483f8b1 
multiverse support
@sunyab
Copy link
Contributor

sunyab commented Mar 13, 2017

I merged this pull request into the dev branch as commit f56da81, with some modifications so that it does not require USD to link directly to multiverse's dependencies. usdAbc must link to a shared library build of multiverse for now. Closing this out, thanks again @asluk!

@sunyab sunyab closed this Mar 13, 2017
@alexwheezy alexwheezy mentioned this pull request Jun 19, 2017
Closed
@asluk asluk deleted the dev_multiverse_support branch March 30, 2019 17:21
@asluk asluk mentioned this pull request May 8, 2019
Closed
@Felix-Kit Felix-Kit mentioned this pull request Feb 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asluk @spiffmon @pberto @sunyab