Skip to content

Commit

Permalink
Fix regex used for processing image references (#131)
Browse files Browse the repository at this point in the history
The regex we use to update image references used in airgap mode fails if
the registry hostname contains a colon.

Signed-off-by: Angel Misevski <[email protected]>
  • Loading branch information
amisevsk authored and monaka committed Nov 25, 2019
1 parent 0f90484 commit 031759b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build/dockerfiles/entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ DEVFILES_DIR="${DEVFILES_DIR:-${DEFAULT_DEVFILES_DIR}}"
# \4 - Image name portion of image, e.g. quay.io/eclipse/(che-theia):tag
# \5 - Tag of image, e.g. quay.io/eclipse/che-theia:(tag)
# \6 - Optional quotation following image reference
IMAGE_REGEX='([[:space:]]*"?)([._a-zA-Z0-9-]*)/([._a-zA-Z0-9-]*)/([._a-zA-Z0-9-]*):([._a-zA-Z0-9-]*)("?)'
IMAGE_REGEX='([[:space:]]*"?)([._:a-zA-Z0-9-]*)/([._a-zA-Z0-9-]*)/([._a-zA-Z0-9-]*):([._a-zA-Z0-9-]*)("?)'

# We can't use the `-d` option for readarray because
# registry.centos.org/centos/httpd-24-centos7 ships with Bash 4.2
Expand Down

0 comments on commit 031759b

Please sign in to comment.