Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

Feature/edit profile loader #2323

Merged
merged 4 commits into from
May 14, 2020
Merged

Conversation

sanjayradadiya
Copy link
Contributor

@sanjayradadiya sanjayradadiya commented May 8, 2020

Fixes #

Changes in this pull request:

  • fix edit profile loader issue
  • fix change password showing error please enter same password message after successfully save password
  • add notification manager for success or error message

@norbertschuler @harshvitra

@sanjayradadiya sanjayradadiya linked an issue May 8, 2020 that may be closed by this pull request
@norbertschuler norbertschuler added the bug Something isn't working label May 8, 2020
Copy link
Collaborator

@norbertschuler norbertschuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. And no, you alone can not refactor the whole app. We must communicate this with the whole team.

app/components/EditUserProfile/index.native.js Outdated Show resolved Hide resolved
app/components/Common/Button/PrimaryButton.native.js Outdated Show resolved Hide resolved
@harshvitra
Copy link
Collaborator

Some comments. And no, you alone can not refactor the whole app. We must communicate this with the whole team.

I don't think it will affect any other part of the app unless the 'loading' props is passed from there.
So this solution can work for Edit Profile

@norbertschuler norbertschuler self-requested a review May 14, 2020 02:33
@norbertschuler
Copy link
Collaborator

Some comments. And no, you alone can not refactor the whole app. We must communicate this with the whole team.

I don't think it will affect any other part of the app unless the 'loading' props is passed from there.
So this solution can work for Edit Profile

O.k, as I have noted the refactoring request on #1837, we can merge this.

@norbertschuler norbertschuler merged commit d77c783 into develop May 14, 2020
@norbertschuler norbertschuler deleted the feature/edit-profile-loader branch May 14, 2020 02:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No visual feedback for profile changes
3 participants