Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new hyperlink redirects and add links to docstring of documentation configuration file #2477

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

namurphy
Copy link
Member

@namurphy namurphy commented Jan 25, 2024

There was an update in sphinx-issues which set the default for the :user: role to point to github.com/sponsors/username instead of github.com/username (sloria/sphinx-issues#129, sloria/sphinx-issues#131). This led to a number of redirects to show up when we did a linkcheck build, so I added a line to docs/conf.py to specify that these redirects should be allowed when doing a linkcheck.

I added some links to the docstring for docs/conf.py that point to helpful locations like our documentation guide and Sphinx's documentation.

I also updated the GitHub username of a past contributor.

@github-actions github-actions bot added the docs PlasmaPy Docs at http://docs.plasmapy.org label Jan 25, 2024
@namurphy namurphy added no changelog entry needed and removed docs PlasmaPy Docs at http://docs.plasmapy.org labels Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1093e93) 96.93% compared to head (b4b3064) 96.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2477   +/-   ##
=======================================
  Coverage   96.93%   96.93%           
=======================================
  Files         104      104           
  Lines        9163     9163           
=======================================
  Hits         8882     8882           
  Misses        281      281           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@namurphy namurphy requested a review from a team as a code owner January 25, 2024 18:49
@namurphy namurphy requested review from ejohnson-96 and removed request for a team January 25, 2024 18:49
@github-actions github-actions bot added docs PlasmaPy Docs at http://docs.plasmapy.org packaging Related to packaging or distribution labels Jan 25, 2024
Copy link
Contributor

@ejohnson-96 ejohnson-96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@namurphy namurphy merged commit 3398357 into PlasmaPy:main Jan 25, 2024
16 checks passed
@namurphy namurphy deleted the linkcheck-github-sponsors-redirect branch January 25, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PlasmaPy Docs at http://docs.plasmapy.org no changelog entry needed packaging Related to packaging or distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants