-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api-v1.1): enable publish API v1.1 #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to improve the documentation page where the users are guided on how to obtain the tokens. But codewise, LGTM! 🚀🚀
Good shout! I've just updated the README |
I've also submitted these two PRs to help enable it on the plasmo ecosystem I think I now understand the bpp monorepo/gitmodule setup (yet to actually set it up), but think I'll still need some guidance from @louisgv on getting it all merged come the new year. |
Is this getting merged soon? I think the endpoint for API 1.0 is already deprecated |
I'm unsure really. I would assume the old API is not working anymore as the deadline was 31 December 2025. I've not had a chance to test these changes, but, IIRC, it does look like the tests may test this. If not, I can likely find some time to test it out myself. @louisgv do you happen to have time to have a look, it would be much appreciated. |
Sorry about the delay, the new year has been pretty hectic! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Start to enable v1.1 of the Publish API, fixing #86.
🚨 This should not be merged until after 31 December 2025.
I was 100% unsure about how to actually test this out / use this repo (pnpm workspace issues) when cloning this by itself. I'm not sure what key file to use in the test as well.
Happy to understand this a bit more and modify the code.
@louisgv if there's any guidance on this, it would be great so I can update docs/readme and contribute more effectively.