Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes runtime when element on page exists with id="process" #2

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

sleekslush
Copy link

In a script context, if you're on a page that has any element w/ id="process", example: <input id="process"> , globalThis.process will point to that element, which is wrong in this context.

Copy link
Contributor

@louisgv louisgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@louisgv louisgv merged commit ea7953b into PlasmoHQ:main Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants