This repository has been archived by the owner on Nov 2, 2018. It is now read-only.
Make serializer a little more forgiving when keys collide. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for sharing this project. This PR addresses something we saw in a production environment where pushed an nlog config change that referenced MDC items in the GelfTcp target that I didn't realize were already passed in eventInfo.Properties. That is, an MDC item had the same name as an nlog event info property. This caused a key collision and an exception in the code that serializes to a JsonObject. That's my bad. But this exception also resulted in 5 retries so one predictable exception became 6 due to retry logic that is really geared toward network transport issues. With multiple exceptions on every other log message sent to the GelfTcp target my nlog config change ended up pegging our CPU. Why not just log this at error or debug level and move on or scope the retry logic down to transport issues? Hope this is helpful.