Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user-defined configs and Row Type Contract parameter. #734

Closed
klntsky opened this issue Jul 14, 2022 · 4 comments · Fixed by #1260
Closed

Remove user-defined configs and Row Type Contract parameter. #734

klntsky opened this issue Jul 14, 2022 · 4 comments · Fixed by #1260
Assignees
Labels
enhancement New feature or request

Comments

@klntsky
Copy link
Contributor

klntsky commented Jul 14, 2022

Reasons:

  • The library does not necessitates using the parameter, and Slack survey exposed little interest in it.
  • It's not hard to provide extra parameters to the contract with ReaderT or simply via an extra argument.
  • the intention was to keep extra configs in Contract, but it's unlikely that Contract is going to be used to manage user application configs/state.

So, it's tangential to the main goal of the library.

The change should happen in v3.

@klntsky klntsky added this to the v3.0.0 milestone Jul 14, 2022
@ngua ngua moved this to Todo in cardano-transaction-lib Jul 14, 2022
@adamczykm
Copy link
Contributor

Assuming I'm implementing a library using Contract monad for its functionality and I want to extend the reader environment, what will be the simplest / most convenient way to do it if we remove 'r' parameter?

@klntsky
Copy link
Contributor Author

klntsky commented Jul 17, 2022

@adamczykm ReaderT.

@adamczykm
Copy link
Contributor

Wrapping it in another readert?

@klntsky
Copy link
Contributor Author

klntsky commented Jul 17, 2022

Yes, we should not assume that our users need some specific monadic stack in their applications. It's up to them to decide how to extend the Contract (or not to extend it at all).

@klntsky klntsky changed the title Remove Row Type Contract parameter. Remove user-defined configs and Row Type Contract parameter. Jul 22, 2022
@ngua ngua added the enhancement New feature or request label Aug 10, 2022
@Luis-omega Luis-omega mentioned this issue Oct 7, 2022
3 tasks
@errfrom errfrom self-assigned this Nov 21, 2022
@jy14898 jy14898 mentioned this issue Dec 1, 2022
3 tasks
@klntsky klntsky removed this from the v3.0.0 milestone Dec 22, 2022
@github-project-automation github-project-automation bot moved this from Todo to Done in cardano-transaction-lib Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

4 participants