Rewrite E2E test suite

[klntsky]

Closes #1058 #989 #986

Pre-review checklist

• All code has been formatted using our config (make format)
• Any new API features or modification of existing behavior is covered as defined in our test plan
• The changelog has been updated under the ## Unreleased header, using the appropriate sub-headings (### Added, ### Removed, ### Fixed), and the links to the appropriate issues/PRs have been included

[klntsky]

Please share your suggestions on how to improve test coverage in a cheap way

[amirmrad]

Puppeteer has a page.url() fn.
So there is no need for Aff. It might be a good idea to rewrite

cardano-transaction-lib/src/Internal/Test/E2E/Wallets.purs

Lines 47 to 55 in d49f112

	findWalletPage :: Pattern -> Toppokki.Browser -> Aff (Maybe Toppokki.Page)
	findWalletPage pattern browser = do
	pages <- Toppokki.pages browser
	walletPages <- fold <$> for pages \page -> do
	try (pageUrl page) <#> hush >>> case _ of
	Nothing -> []
	Just url
	| String.contains pattern url -> [ page ]
	| otherwise -> []

into something like:

findWalletPage :: Pattern -> Toppokki.Browser -> Aff (Maybe Toppokki.Page)
findWalletPage pattern browser = do
  pages <- Toppokki.pages browser

  let walletPages = do
          page <- pages
          guard $ String.contains pattern (_url page)
          pure page
-- ...

where _url is foreign import _url :: Toppokki.Page -> String

[klntsky]

It might be a good idea to rewrite

I don't agree, using a library function with the same purpose is better than using FFI.

[amirmrad]

Yes, but pageUrl is not a library function:

pageUrl :: Toppokki.Page -> Aff String
pageUrl page = do
  unsafeFromForeign <$> Toppokki.unsafeEvaluateStringFunction
    "document.location.href"
    page

Anyways, it's not a big deal, just something I noticed.

[amirmrad]

Not relevant, there is no String param.

[jy14898]

This should still be in Effect

[jy14898]

LGTM