Blockfrost metadata and confirmation #1368
Conversation
jy14898
force-pushed
the
jy14898/blockfrost-metadata-and-confirmation
branch
from
5961421 to
b8634b5
Compare
…behaviour of metadata fetching in kupo and blockfrost.
…tadata-and-confirmation
| case unwrapKupoMetadata kupoMetadata of | ||
| Nothing -> throwError GetTxMetadataMetadataEmptyOrMissingError | ||
| Just metadata | ||
| | Map.isEmpty (unwrap metadata) -> throwError |
There was a problem hiding this comment.
Why we need to handle empty Map case?
There was a problem hiding this comment.
To make the API the same for blockfrost and kupo.
Blockfrost gives us the same information in the empty metadata case, regardless of whether it actually had the optional metadata field attached. Kupo on the other hand returns exactly what the transaction contained,
The alternative could be to always make the kupo version return an empty metadata on the case where there was none, but I think if users are requesting metadata from a transaction, they probably expect some metadata.
There was a problem hiding this comment.
Not sure if I explained that well, maybe this makes it clearer:
No metadata:
blockfrost: []
kupo: []
Empty metadata:
blockfrost: []
kupo: [ ... ]
With metadata:
blockfrost: [ ... ]
kupo: [ ... ]
…tadata-and-confirmation
jy14898
changed the title
| @@ -88,14 +88,14 @@ runBlockfrostServiceM backend = flip runReaderT serviceParams | |||
| -------------------------------------------------------------------------------- | |||
|
|
|||
| data BlockfrostEndpoint | |||
| = GetTransaction TransactionHash | |||
| | GetTransactionMetadata TransactionHash | |||
| = Transaction TransactionHash | |||
There was a problem hiding this comment.
In theory an endpoint can support multiple HTTP methods, GET/POST/PUT/DELETE etc. It also looked a little redundant seeing blockfrostGetRequest $ Get...
Part of #1365
Pre-review checklist
make format)## Unreleasedheader, using the appropriate sub-headings (### Added,### Removed,### Fixed), and the links to the appropriate issues/PRs have been included