Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move provider and other types to separate packages #1671

Merged
merged 19 commits into from
Feb 4, 2025

Conversation

KristianBalaj
Copy link
Collaborator

@KristianBalaj KristianBalaj commented Jan 31, 2025

Closes #1660

Multiple dependent PRs:

TODO:

  • Change the referenced revisions of cardano-types to be in the mlabs-haskell GH org

Pre-review checklist

  • All code has been formatted using our config (make format)
  • Any new API features or modification of existing behavior are covered with tests
  • The template (templates/ctl-scaffold) has been updated
  • The changelog has been updated under the ## Unreleased header, using the appropriate sub-headings (### Added, ### Changed, ### Removed, ### Fixed), and the links to the appropriate issues/PRs have been included

@KristianBalaj KristianBalaj changed the title [WIP] Move provider and other types to separate packages Move provider and other types to separate packages Feb 3, 2025
@KristianBalaj KristianBalaj marked this pull request as ready for review February 3, 2025 10:22
@KristianBalaj KristianBalaj requested a review from errfrom February 3, 2025 10:49
Copy link
Collaborator

@errfrom errfrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

packages.dhall Outdated Show resolved Hide resolved
src/Contract/Time.purs Outdated Show resolved Hide resolved
templates/ctl-scaffold/packages.dhall Show resolved Hide resolved
@errfrom errfrom merged commit 2586ef6 into develop Feb 4, 2025
3 checks passed
@errfrom errfrom deleted the provider-extraction-2 branch February 4, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract Provider (QueryHandle) to a separate package
2 participants