Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref#2195 - META - change PDF export code #2232

Closed
wants to merge 4 commits into from

Conversation

Gaetanbrl
Copy link
Contributor

@Gaetanbrl Gaetanbrl commented Dec 21, 2022

PR dans le cadre d'une contribution financée par MNHN / PatriNat
ref #2195

Cette PR modifie la génération des PDF de métadonnées :

  • Aucun fichier (temporaire) n'est déposé sur le serveur (suppression de la méthode upload_canvas)
  • L'image est ajoutée en tant que data URL b64 dans la source de l'image du template/HTML
  • La création du PDF se réalise via un seul appel
  • Réutilisation de la méthode subscribeAndDownload
  • Correction du graph qui n'était pas ajouté dans l'export PDF d'une AF - META / AF - Graphique non présent dans l'export PDF #2231
  • Modification de la route (POST à la place de GET). L'envoi d'un objet/json dans le body permet de se soustraire des problèmes d'encodage que l'on a pu voir lorsque l'image était directement passée dans le body en tant que type data et qui empêché la bonne représentation dune image type data URL dans le template HTML du PDF (voir méthode render Weasyprint).

En cours sur cette PR :

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 67.72% // Head: 67.85% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (c3e1af5) compared to base (6bd8ab2).
Patch coverage: 81.81% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2232      +/-   ##
===========================================
+ Coverage    67.72%   67.85%   +0.13%     
===========================================
  Files           83       83              
  Lines         7358     7367       +9     
===========================================
+ Hits          4983     4999      +16     
+ Misses        2375     2368       -7     
Flag Coverage Δ
pytest 67.85% <81.81%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
backend/geonature/core/gn_meta/mtd/mtd_utils.py 14.74% <ø> (ø)
backend/geonature/core/gn_meta/routes.py 78.53% <77.77%> (+0.99%) ⬆️
backend/geonature/utils/filemanager.py 62.74% <100.00%> (-1.41%) ⬇️
backend/geonature/core/gn_meta/mtd/__init__.py 35.71% <0.00%> (-7.15%) ⬇️
backend/geonature/core/users/routes.py 54.08% <0.00%> (-0.56%) ⬇️
backend/geonature/middlewares/__init__.py 100.00% <0.00%> (ø)
backend/geonature/core/gn_permissions/models.py 93.97% <0.00%> (+0.07%) ⬆️
backend/geonature/utils/config_schema.py 91.86% <0.00%> (+0.10%) ⬆️
backend/geonature/app.py 83.33% <0.00%> (+0.15%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

display AF chart int PDF

PnX-SI#2034 - fix actors info in dataset PDF
Copy link
Contributor

@bouttier bouttier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lorsque l’on clique sur le bouton téléchargé, le navigateur ne comprend pas qu’il s’agit d’un PDF et ne propose pas de l’ouvrir avec un lecteur PDF. À priori cela provient du fait que le backend répond avec un Content-Type text/html plutôt que application/pdf. Est-il possible de corriger ce soucis ? Merci !

backend/geonature/core/gn_meta/routes.py Outdated Show resolved Hide resolved
backend/geonature/core/gn_meta/routes.py Outdated Show resolved Hide resolved
backend/geonature/tests/test_gn_meta.py Outdated Show resolved Hide resolved
backend/geonature/tests/test_gn_meta.py Outdated Show resolved Hide resolved
backend/geonature/tests/test_gn_meta.py Outdated Show resolved Hide resolved
backend/geonature/tests/test_gn_meta.py Outdated Show resolved Hide resolved
backend/geonature/tests/test_gn_meta.py Outdated Show resolved Hide resolved
frontend/src/app/GN2CommonModule/form/data-form.service.ts Outdated Show resolved Hide resolved
frontend/src/app/metadataModule/af/af-form.component.ts Outdated Show resolved Hide resolved
@Gaetanbrl
Copy link
Contributor Author

Est-il possible de corriger ce soucis ? Merci !

Testé avec application/pdf et ca permet seulement de le sauvegarder en l'état.

image

Il faut aussi potentiellement l'ouvrir côté front et pas seulement changer le content-type.

 use pdf content-type with meta export

command to check js code style before push

change prettier check commande
@Gaetanbrl Gaetanbrl force-pushed the issue-2195 branch 2 times, most recently from 5a816b2 to c3e1af5 Compare December 26, 2022 15:08
@Gaetanbrl
Copy link
Contributor Author

Il faut aussi potentiellement l'ouvrir côté front et pas seulement changer le content-type.

Modifications faites.

@bouttier bouttier mentioned this pull request Jan 4, 2023
@bouttier
Copy link
Contributor

bouttier commented Jan 4, 2023

Supersed by #2241

@bouttier bouttier closed this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants