Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/synthese search group3 inpn #2621

Merged

Conversation

mvergez
Copy link
Contributor

@mvergez mvergez commented Jul 6, 2023

Bonjour,

Dans le cadre d'une prestation pour l'Agence Régionale de la Biodiversité en île de France, une demande a été faite pour intégrer le groupe3_inpn dans GeoNature.

L'objectif est tout d'abord de l'intégrer dans la recherche avancée de la taxonomie dans la synthèse.

Attention cette PR part du principe qu'une nouvelle route vers Taxhub est disponible ainsi que le modèle ORM de Taxref dispose de l'attribut group3_inpn. Cette PR incluant cette route est disponible ici : PnX-SI/TaxHub#409

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4fa10e5) 78.44% compared to head (cdd1a86) 68.34%.
Report is 11 commits behind head on feat/groupinpn3.

❗ Current head cdd1a86 differs from pull request most recent head a57dbb9. Consider uploading reports for the commit a57dbb9 to get more accurate results

Files Patch % Lines
...nature/core/gn_synthese/utils/query_select_sqla.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           feat/groupinpn3    #2621       +/-   ##
====================================================
- Coverage            78.44%   68.34%   -10.10%     
====================================================
  Files                   89       84        -5     
  Lines                 7213     7424      +211     
====================================================
- Hits                  5658     5074      -584     
- Misses                1555     2350      +795     
Flag Coverage Δ
pytest 68.34% <33.33%> (-10.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camillemonchicourt camillemonchicourt added this to the 2.14 milestone Nov 13, 2023
@jacquesfize jacquesfize force-pushed the feat/synthese_group3_inpn branch from f3959b8 to 181e15f Compare January 26, 2024 16:17
@jacquesfize jacquesfize marked this pull request as ready for review January 26, 2024 16:17
@jacquesfize jacquesfize changed the base branch from develop to feat/groupinpn3 January 26, 2024 16:30
@jacquesfize jacquesfize mentioned this pull request Feb 9, 2024
4 tasks
@jacquesfize jacquesfize force-pushed the feat/synthese_group3_inpn branch from 181e15f to 5bb08cf Compare February 9, 2024 12:34
@jacquesfize jacquesfize merged commit 0dc4400 into PnX-SI:feat/groupinpn3 Feb 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants