Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Redirection du bouton Accueil dans la page d'accueil de GeoNature #2941

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

jacquesfize
Copy link
Contributor

Lorsque GeoNature est accessible depuis une URL avec un suffixe (demo.geonature.fr/geonature), la redirection du bouton Accueil de la page d’accueil ignore ce dernier (demo.geonature.fr/).

Cette PR propose un fix.

Issue à l'origine #2934

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.50%. Comparing base (ec1f160) to head (876a139).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2941   +/-   ##
=======================================
  Coverage   78.50%   78.50%           
=======================================
  Files          89       89           
  Lines        7208     7208           
=======================================
  Hits         5659     5659           
  Misses       1549     1549           
Flag Coverage Δ
pytest 78.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camillemonchicourt
Copy link
Member

Mais si les gens l'ont sur une autre URL que /geonature ?
Ça peut être tout autre chose, donc à ne pas mettre en dur dans le code ?

@jacquesfize
Copy link
Contributor Author

Le /geonature c'était pour l'exemple :) Normalement, ça devrait être générique :)

@Pierre-Narcisi Pierre-Narcisi changed the base branch from master to develop March 14, 2024 14:35
@Pierre-Narcisi Pierre-Narcisi merged commit b929fb3 into develop Mar 14, 2024
9 checks passed
@Pierre-Narcisi Pierre-Narcisi deleted the fix/homebutton_bad_redirect branch March 14, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants