feat: add route to tabs synthese info #3169
Conversation
- Manage dynamic tabs displayed (using tabs object with path and label) - Add route 'occurrence/:id_synthese/:tab' - Add manage event when modal is closed (go back to module 'synthese') - Apply lint frontend - Add "TODO" --> delete openInfoModal in syntheseListComponent because using routerLink to openModal Reviewed-by: andriacap
|
Comme le routing En faisant pointer la route |
| @@ -151,6 +153,8 @@ export class SyntheseListComponent implements OnInit, OnChanges, AfterContentChe | |||
| link.remove(); | |||
| } | |||
|
|
|||
| // TODO: cette method peut être supprimé car redondante avec celle appelée dans syntheseComponent https://github.com/PnX-SI/GeoNature/blob/a6a9c05acfa8a0a2f7aecbb70e6deacdb250b2c4/frontend/src/app/syntheseModule/synthese.component.ts#L222 | |||
| // car le composant est monté via la route /occurence/:id_synthese/:tab | |||
(to avoid synthese component reloading)
… redirection to a tab of the synthese obs component
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3169 +/- ##
========================================
Coverage 81.76% 81.76%
========================================
Files 86 86
Lines 6976 6976
========================================
Hits 5704 5704
Misses 1272 1272
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
T'as testé ça ? |
Concernant le TODO, pour moi on peut tout simplement supprimer la method "openInfoModal" vu qu'on utilise dans les devs proposés une manière plus classique à savoir l'utilisation du routerLink.
[Refs_Issue] : #3155
Reviewed-by: andriacap