Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for a CMake integration #11

Merged
merged 3 commits into from
Nov 5, 2020

Conversation

kunaltyagi
Copy link
Member

@kunaltyagi kunaltyagi commented Oct 25, 2020

  • Changes to make it more intuitive to use
  • Add a sample (simple?) CMake project

Current usage (<> means path to)

  • build the project
  • goto build directory
  • python <parse> --com ./ ../src/simple.cpp
  • python <generate> json/src/simple.json

TODO (future PRs)

  • single script for end-to-end generation
  • CMake generator (or compile_database generator)
  • compile_database_path is actually path to the dir containing it

@ximenesfel
Copy link

Looking at the description of PR, there are some TODOs. Can I help working in this topics? Or maybe in another task?

@kunaltyagi kunaltyagi merged commit 410503c into PointCloudLibrary:master Nov 5, 2020
@kunaltyagi kunaltyagi deleted the cmake-integration branch November 5, 2020 23:41
@kunaltyagi
Copy link
Member Author

kunaltyagi commented Nov 5, 2020

#14 actually tackles the TODO items. Please take a look at the open issues to jump on things.

You can add different tests so we cover more of C++ (so many things need to be tested.... it's mind boggling)

@ximenesfel
Copy link

@kunaltyagi thanks for response. I will look the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants