Index out of range in OrganizedConnectedComponentSegmentation

[mtsep]

Hi,
I think there is a bug in the bounds checking code in the file organized_connected_component_segmentation.hpp, line 103:

if (x >= 0 && y < int(labels->width) && y >= 0 && y < int(labels->height) && labels->points[index].label == label)
break;

Looks like the code y < int(labels->width) should really be x < int(labels->width).
Current code leads to labels->points[index] crashing when index out of bounds (x too high).

Error encountered in PCL Version 1.7.2, but looks like it is still present in the version 1.8.0

[jspricke]

Sounds right, can you send a pull request?

[mtsep]

Ok I made a pull request with this bugfix.
Hopefully everything is correct with the fork/branch, since I'm kind of new in GitHub.

[jspricke]

You need to create the pull request against the pcl repo ;). Also, please add some more comments to the commit.

[mtsep]

Alright, another try :)