Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] CPPF Implementation #280

Closed
aichim opened this issue Sep 27, 2013 · 7 comments
Closed

[Feature Request] CPPF Implementation #280

aichim opened this issue Sep 27, 2013 · 7 comments

Comments

@aichim
Copy link
Member

aichim commented Sep 27, 2013

Ran into this paper today: http://www.cc.gatech.edu/~cchoi/Publications_files/Choi12iros_3d.pdf

It's basically the PPF we have already in the features module with additional color information. It would be a nice starter task for someone that wants to contribute to PCL. In the process, it would also be nice to re-check the correctness of PPF.

@andersgb1
Copy link
Contributor

Regarding, re-checking PPF, maybe the task could be to simply reproduce the
results (recognition rate vs. occlusion) on the Mian dataset from the
original paper?

On 27 September 2013 09:54, aichim [email protected] wrote:

Ran into this paper today:
http://www.cc.gatech.edu/~cchoi/Publications_files/Choi12iros_3d.pdf

It's basically the PPF we have already in the features module with
additional color information. It would be a nice starter task for someone
that wants to contribute to PCL. In the process, it would also be nice to
re-check the correctness of PPF.


Reply to this email directly or view it on GitHubhttps://github.com//issues/280
.

@aichim
Copy link
Member Author

aichim commented Sep 27, 2013

I think I did that when I originally implemented it, but having a second pair of eyes look at it is never bad :-)

@andersgb1
Copy link
Contributor

Ah, I see :)

On 27 September 2013 10:03, aichim [email protected] wrote:

I think I did that when I originally implemented it, but having a second
pair of eyes look at it is never bad :-)


Reply to this email directly or view it on GitHubhttps://github.com//issues/280#issuecomment-25229046
.

@mszarski
Copy link
Contributor

mszarski commented Oct 1, 2013

Hi guys,

I've committed a simple implementation of CPPF using normalised HSV values in the feature vector to a local fork here: https://github.com/mszarski/pcl/compare/cppf-impl.
The code includes a single unit test.

Before I issue the pull request, was normalised HSV what you intended for PCL?

@jspricke
Copy link
Member

@aichim any comments on @mszarski question? Otherwise I'm fine with merging #296. Thanks for the ocntribution!

@aichim
Copy link
Member Author

aichim commented Oct 11, 2013

@mszarski , thanks for your quick contribution. It would be really interesting to have a little example application that compares the performance of the two techniques on a couple of RGB-D frames.

jspricke added a commit that referenced this issue Oct 17, 2013
CPPF Feature Implementation per issue #280
@rbrusu
Copy link
Member

rbrusu commented Dec 16, 2013

Seems like this was solved, closing.

@rbrusu rbrusu closed this as completed Dec 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants