-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows VS2013: pcl_gpu_people & pcl_segmentation compilation errors & fixes #924
Comments
Wow, Visual Studio can't deduce that SupervoxelHelper is a typename from within the SupervoxelHelper class definition? That's dumb. I'll add it. |
jpapon
added a commit
to jpapon/pcl
that referenced
this issue
Sep 23, 2014
Thanks for the heads up - our test build doesn't use VS =) |
Glad I could help =) |
Fixed via #925. |
gcasey
pushed a commit
to gcasey/pcl
that referenced
this issue
Sep 23, 2014
…nce-estimate * gh/master: (166 commits) Fixes for issue PointCloudLibrary#924 Fix setSize () in PCL visualizer PCL formula is in the official homebrew repo CMake pkg_check_modules sets GLEW_INCLUDEDIR Fix for Mac OS X Changes necessary for lccp pull request PointCloudLibrary#718 Change to visualization to make things a bit nicer - mainly removed broken opacity Updated supervoxel examples with normals and better description of the camera transform Removed public interface for modifying neighbors of OctreePointcloudAdjacencyContainer. Neighbors can now only be added/removed from within OctreePointcloudAdjacency. This does *not* mean neighbors can't be modified, just that the list of neighbors itself can't be modified. Fix for problem where leaves could get lost, and warning would show up. Now we use leaf indices directly for seeding, instead of doing a look up Changed OctreePointcloud Adjacency to use std::list instead of std::set, added comparator to SupervoxelHelper so that the internal set of voxels owned by a helper is sorted by index instead of memory location Added brief comment explaining comparator Fix inconsistency between method declaration and implementation that resulted in build failure Remove Boost Chrono dependency Don't normalize path if function is not in Boost Disable precompilation of PPFRegistration Fix for issue PointCloudLibrary#758 Moved pcl::PPFHashMapSearch::setInputFeatureCloud() and pcl::PPFHashMapSearch::nearestNeighborSearch() implementation from ppf_registration.hpp to ppf_registration.cpp since they belong to a not templated class Bump PCL version to 1.8.0 Fixes PointCloudLibrary#896. Add a changelist for 1.7.2 Set PCL_ONLY_CORE_POINT_TYPES on Windows (Closes PointCloudLibrary#833) ... Conflicts: common/include/pcl/common/impl/centroid.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please be patient. This is my first bug report ever...
I am using the current head of master (89ec4f9) on Windows 8.1 x64 with Visual Studio 2013 Professional.
I was not able to compile both pcl_gpu_people & pcl_segmentation because of errors.
pcl_segmentation:
in supervoxel_clustering.h line 415 the template declaration for windows seems to be incorrect.
instead of
typedef std::set<LeafContainerT*, SupervoxelHelper::compareLeaves> LeafSetT;
it seems it should read
typedef std::set<LeafContainerT*, typename SupervoxelHelper::compareLeaves> LeafSetT;
pcl_gpu_people:
in NCU.cu std::max is used. However in order to use it, it is necessary to
#include <algorithm>
I hope this helps. Im not sure if it breaks anything on other platforms which is why I did not prepare a pull request...
The text was updated successfully, but these errors were encountered: