Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eigen with std::vector fixes #1034

Merged
merged 1 commit into from
Dec 14, 2014
Merged

Eigen with std::vector fixes #1034

merged 1 commit into from
Dec 14, 2014

Conversation

VictorLamoine
Copy link
Contributor

Fixes #958

$ grep "std::vector<Eigen" -rn /home/$USER/pcl | grep -vw 'aligned_allocator'
/home/victor/pcl/recognition/include/pcl/recognition/face_detection/rf_face_detector_trainer.h:230:      void getDetectedFaces(std::vector<Eigen::VectorXf> & faces)
/home/victor/pcl/apps/include/pcl/apps/face_detection/face_detection_apps_utils.h:112:  void displayHeads(std::vector<Eigen::VectorXf> & heads, pcl::visualization::PCLVisualizer & vis)
/home/victor/pcl/apps/src/face_detection/openni_face_detection.cpp:70:    std::vector<Eigen::VectorXf> heads;
/home/victor/pcl/apps/src/face_detection/filesystem_face_detection.cpp:85:  std::vector<Eigen::VectorXf> heads;

These are fine: http://eigen.tuxfamily.org/dox/group__TopicFixedSizeVectorizable.html

@VictorLamoine
Copy link
Contributor Author

Building is ok on my side

@taketwo
Copy link
Member

taketwo commented Dec 8, 2014

Hi Victor, thanks for the effort. Unfortunately I've been quite busy lately and do not have enough time to go through all the piled up requests. But I'll have a look asap.

@VictorLamoine
Copy link
Contributor Author

We are not in a hurry; take your time!

@jspricke
Copy link
Member

I had a quick look, and as it seems to be more or less automatically generated, I would merge it tomorrow, if no one objects.

@taketwo
Copy link
Member

taketwo commented Dec 14, 2014

+1

jspricke added a commit that referenced this pull request Dec 14, 2014
@jspricke jspricke merged commit 3b86719 into PointCloudLibrary:master Dec 14, 2014
@VictorLamoine VictorLamoine deleted the eigen_fixes branch December 15, 2014 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eigen alignment issue
3 participants