Fix VTK compatibility #1056
Merged
Fix VTK compatibility #1056
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's not working for me for VTK 6.1.1: |
|
From what I remember I tested with VTK 6.1 release. If that doesn't work for you add a VTK version condition. |
Merged
|
It seems like in VTK 6.1.0 the code bellow is still required |
|
Could you submit a pull request with refined |
|
Aha! I was (partially) right 😃 These changes in VTK are annoying! |
|
Yes, they are. Would be nice to have some middle layer to abstract this stuff or move away from vtk5. It would be nice to remove all this #ifdefs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fran6co@4d1ee47#diff-4206b5bbfa76680243fec88c91dfbd3cL119 removed the update call which is in fact needed for VTK 5. It does not hurt VTK 6 support.
Reported by Ber461 on the mailing list.