Change default behavior of SupervoxelClustering #1115
Conversation
|
|
|
Sounds good! Are we allowed to use c++11 features yet (in this case, delegating constructors)? Also, how should I be handling improvements to the supervoxel algorithm itself? For instance, I now have a much better algorithm for choosing seed points. Do you think it's okay to simply drop it in, even though it significantly changes the overall end result? |
There were no discussions of this issue recently, so I guess no. Anyways, it doesn't make much sense to introduce this requirement for such a minor reason.
Good question! Actually I do not know our policy on that. @jspricke @rbrusu? |
If it only improves the output, I think it should be fine to replace it. |
|
Got it. Then in this case I would suggest to silently replace the seeding function. The old one was a trivial hack, probably does not deserve to be preserved for future :) |
| @@ -189,7 +189,10 @@ namespace pcl | |||
| * \param[in] seed_resolution The average size (in meters) of resulting supervoxels | |||
| * \param[in] use_single_camera_transform Set to true if point density in cloud falls off with distance from origin (such as with a cloud coming from one stationary camera), set false if input cloud is from multiple captures from multiple locations. | |||
There was a problem hiding this comment.
This parameter no longer exists.
|
Jeremie, we don't get notifications when new commits are added to a pull request. Thus I have no way of knowing that you addressed my requests unless you drop a comment. |
|
Yeah... my bad. Should be good now though. |
|
|
||
| .. literalinclude:: sources/supervoxel_clustering/supervoxel_clustering.cpp | ||
| :language: cpp | ||
| :lines: 73-77 | ||
| :lines: 73-79 |
There was a problem hiding this comment.
Are the line numbers still valid?
jpapon
force-pushed
the
supervoxel_transform_fix
branch
from
969fb90 to
add33bb
Compare
|
Should be all good now, forgot about those damn tutorial links |
…, not if unorganized. Can still force behavior with function Typo fixes Added deprecated constructor with boolean parameter for controlling the transform behavior) Improved documentation for single camera transform Added included to tutorial, updated to use label cloud Fixed lines numbers in Supervoxel clustering tutorial
jpapon
force-pushed
the
supervoxel_transform_fix
branch
from
add33bb to
43ad1f8
Compare
|
Thanks, LGTM now. |
Change default behavior of SupervoxelClustering
Supervoxel clustering now uses the depth dependent transform by default only if the input cloud is organized.
A function was added for forcing/disabling use of the transform, and the parameter for its use was removed from the constructor.
Examples/Tutorials were updated to reflect these changes.