Improve the PLY parser to work around some issues on Mac OSX #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is (controversially) a bug in some version of libc++ where attempting to read std::ws at eof would trigger the failbit. This change removes the std:ws read attempts at statement ends as a workaround. It obviously loosens up the validation and allows extra characters towards the end of line, however it would still be better than rejecting entirely valid PLY files. A discussion around the original issue can be found here: http://stackoverflow.com/questions/13423514/should-stdws-raise-failbit-at-end-of-file
Instead of erroring out, it now simply warns that there are extra data found and ignored beyond the pre-specified number of elements.
|
Thanks for contributing! |
taketwo
added a commit
that referenced
this pull request
Feb 28, 2015
Improve the PLY parser to work around some issues on Mac OSX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a couple of PLY files generated by VisualSFM. They keep getting rejected on Mac OSX by pcl_ply2pcd with simply "parsing error" messages. After debugging I found out that it was mostly caused by some intricacies in how streams are handled by some versions of libc++ on Mac OSX. This series of commits works around the issues, at the cost of slightly loosened up parsing validation.