Store required sample size inside SampleConsensusModel classes #1396
+84
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -68,7 +68,9 @@ namespace pcl | |||
| }; | |||
| } | |||
|
|
|||
| // Define the number of samples in SacModel needs | |||
| // Warning: this array is deprecated and is kept only to prevent breaking | |||
There was a problem hiding this comment.
Can we use PCL_DEPRECATED here and below?
There was a problem hiding this comment.
Hm, actually yes. For some reason I thought that depreciation attribute can not be applied to variables.
taketwo
force-pushed
the
sac-refactoring-3
branch
from
a819bd3 to
f15ea66
Compare
|
Done. |
jspricke
added a commit
that referenced
this pull request
Oct 24, 2015
Store required sample size inside SampleConsensusModel classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #987.