Fixes incorrect distance calculation in getMaxDistance #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes PointCloudLibrary#1449. getMaxDistance was using the norm of a Eigen::Vector4f to compute the 3D distance between points. The norm was using the 4th element of xyz/data[4] which is often just bit trash. When an index vector is provided, the function was returning the wrong point. Added tests for both
jspricke
added a commit
that referenced
this pull request
Nov 29, 2015
Fixes incorrect distance calculation in getMaxDistance
|
Great work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1449. getMaxDistance was using the norm of a
Eigen::Vector4fto compute the 3D distance between points. The norm was using the 4th element of xyz/data[4] which is often just bit trash. When anindex vector is provided, the function was returning the wrong point. Added tests for both