-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error C3016 on MSVC with OpenMP #1527
Conversation
Why specifically |
I think that |
On pre-c++11 compilers these types are available through Boost. We import them in |
45e2292
to
9806499
Compare
OK, I changed for-loop index to |
MSVC doesn't support an OpenMP versions earlier higher than 2.0. The index variable in an OpenMP 2.0 for statement must be a signed integral type.
9806499
to
2037c89
Compare
Thanks! |
@taketwo Why closed this pull-request? Don't merge this commit? |
Fix error C3016 on MSVC with OpenMP
Ooooops, sorry. Thanks for the heads-up ;) |
Thanks. |
This pull request was fixed error C3016 (issue #1499).
MSVC doesn't support an OpenMP versions earlier higher than 2.0.
The index variable in an OpenMP 2.0 for statement must be a signed integral type.
The error C3016 occurs on MSVC, because
std::size_t
is unsigned integral type.Fix this issue by replacing index to the 64bit signed integral type.