Don't set VTK_LIBRARIES manually #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a current Debian unstable system this results in: /usr/bin/ld: cannot find -lQt5::Widgets I assume that it made sense when we required only some of the VTK libraries, but setting it to all doesn't make a difference, unless your system is different to the one PCL was compiles on.
|
So if I understand correctly, before your change, assuming you had a project which had a dependency on VTK, this was overwriting the |
|
@SergioRAgostinho exactly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a current Debian unstable system this results in:
/usr/bin/ld: cannot find -lQt5::Widgets
I assume that it made sense when we required only some of the VTK
libraries, but setting it to all doesn't make a difference, unless your
system is different to the one PCL was compiles on.