Remove MSVCdd variables #1830
Merged
Remove MSVCdd variables #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version check for MSVC with MSVC_VERSION variable instead of MSVCdd variables, because MSVCdd variables are legacy. (e.g. MSVCdd is not defined for Visual C++ 2017.)
|
cmake/pcl_targets.cmake#L199-L201 have similar problem, but it is resolved by merge the PR #1823 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version check for Visual C++ with
MSVC_VERSIONvariable instead ofMSVCddvariables, becauseMSVCddvariables are legacy. (e.g.MSVCddis not defined for Visual C++ 2017.)