Suppress log when PCL_FIND_QUIETLY is turned on. #2032
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PCLConfig.cmake.in
Outdated
| @@ -183,6 +183,10 @@ endmacro(find_qhull) | |||
|
|
|||
| #remove this as soon as libopenni is shipped with FindOpenni.cmake | |||
| macro(find_openni) | |||
| if(PCL_FIND_QUIETLY) | |||
| set(openni_FIND_QUIETLY TRUE) | |||
There was a problem hiding this comment.
It doesn't seem to be all lowercase in case of OpenNI2. (PCLConfig.cmake.in#L223)
If there is no reason, Please adjust accordingly.
- set(openni_FIND_QUIETLY TRUE)
+ set(OpenNI_FIND_QUIETLY TRUE)There was a problem hiding this comment.
The only reason to use all lowercase is because it should be the same as the first parameter in the call find_package_handle_standard_args.
Line 211 in 41783c7
I'll change them all.
There was a problem hiding this comment.
I think it is good. Thanks,
|
@SergioRAgostinho @taketwo If you don't have other comments about this pull request, I think ready to merge. Please review this pull request. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change will suppress
find_package_handle_standard_args(openni DEFAULT_MSG OPENNI_LIBRARY OPENNI_INCLUDE_DIRS)from emitting a log.