Enable Global Tests on Windows CI #2137

UnaNancyOwen · 2017-12-10T15:33:25Z

Enable Global Tests on Windows CI. #2136

UnaNancyOwen · 2017-12-10T15:49:10Z

Oops, It is failed installing google test with Vcpkg.
Please wait for fixes it... microsoft/vcpkg#2345

SergioRAgostinho · 2017-12-10T18:40:03Z

.appveyor.yml

          -DBUILD_examples=OFF
          -DBUILD_tools=OFF
          -DBUILD_apps=OFF
          ..
  - cmake --build . --config %CONFIGURATION%
+  - ctest -C %CONFIGURATION% -V


Don't forget to add this new line later.

SergioRAgostinho · 2017-12-13T11:25:30Z

Nice digging on that request thread ^^

UnaNancyOwen · 2017-12-14T04:31:12Z

Tests for Visual Studio 2015 (x86) were finished without timeout. (1hours 17min.)
But, Tests for Visual Studio 2015 (x64) were timed out. It is necessary a little more tricks.
I think that it would be good to try the Ninja build system. Also, I think it is necessary to consider that we ask AppVeyor to assign faster instances or more timeout limits.
Do you have any ideas?

SergioRAgostinho · 2017-12-14T04:54:33Z

If you replicate the pattern we have on Travis to split the tests in 2 or 3 different jobs, the problem should be solved.

UnaNancyOwen · 2017-12-18T09:46:09Z

I was implemented Tests with Ninja build tool. Probably, It is building faster than MSBuild.
Tests for x64 still time-out. But, That is on state that 3rdParty was still not cached.
I think test for x64 will exit without time-out if it is on state that 3rdParty was cached.
(3rdParty installation process took about 20 min. It will exit soon if it is state on that 3rdParty cached.)

By default, AppVeyor has disabled saving cache in pull request builds.
Therefore, We need to temporarily turn ON "Save build cache in Pull Requests" option to caching 3rdParty. (That option will necessary to turn off after cashed right away because it will affect other pull requests too.)
https://www.appveyor.com/docs/build-cache/#saveupdate-cache-before-build-finishes

UnaNancyOwen · 2017-12-18T11:03:04Z

What do you think about failed tests.
We can temporarily turn off these tests until fixed.
(But, I think these tests should preferably be fixed.)

93% tests passed, 7 tests failed out of 104

The following tests FAILED:
	  1 - test_2d (Failed)
	 13 - common_eigen (Failed)
	 23 - feature_rift_estimation (Failed)
	 25 - feature_cppf_estimation (Failed)
	 27 - feature_pfh_estimation (Failed)
	 50 - filters_sampling (Failed)
	 68 - io_grabbers (Failed)

UnaNancyOwen · 2017-12-18T23:23:21Z

@SergioRAgostinho I don't want to split the tests job. If possible, I think that it is good to keep simple.
Please review this yaml that build tests with Ninja build tools.
I think it is ready to merge after 3rdParty cached and confirm to exit without timeout.
Also, If it is necessary to temporarily disable failed tests, I will push a commit to do it.
What do you think?

SergioRAgostinho

I think it is ready to merge after 3rdParty cached and confirm to exit without timeout.

I'm ok with that. I assume you have permissions for doing this on your own, as a member of the PCL team.

Also, If it is necessary to temporarily disable failed tests, I will push a commit to do it.

Also fine by me.

SergioRAgostinho · 2017-12-19T00:19:21Z

.appveyor.yml

-    #   Platform: x64
+    - APPVEYOR_BUILD_WORKER_IMAGE: 'Visual Studio 2015'
+      PLATFORM: x86
+      GENERATOR: 'Ninja'


If GENERATOR: 'Ninja' is valid for all jobs, you might was well simply add it as a global env, just like VCPKG_DIR and NINJA_DIR.

SergioRAgostinho · 2017-12-19T00:25:30Z

CMakeLists.txt

@@ -206,6 +206,9 @@ set(PCL_OUTPUT_BIN_DIR "${PCL_BINARY_DIR}/${BIN_INSTALL_DIR}")
 make_directory("${PCL_OUTPUT_LIB_DIR}")
 make_directory("${PCL_OUTPUT_BIN_DIR}")
 if(WIN32)
+  set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY "${PCL_OUTPUT_LIB_DIR}")
+  set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${PCL_OUTPUT_BIN_DIR}")
+  set(CMAKE_LIBRARY_OUTPUT_DIRECTORY "${PCL_OUTPUT_BIN_DIR}")


Notice that now we can move

set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY "${PCL_OUTPUT_LIB_DIR}") set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${PCL_OUTPUT_BIN_DIR}")

out of the if/else(WIN32) conditionals, since if became common to all platforms.

UnaNancyOwen · 2017-12-19T23:50:04Z

I temporarily turned ON "Save build cache in Pull Requests" option for make 3rdParty cache.
It turns OFF after cache was created.

UnaNancyOwen · 2017-12-20T00:07:12Z

Hmm, The boost port was updated while creating cache.
I think need fix to upstream. I will redo this after fixed.

UnaNancyOwen · 2017-12-20T01:16:43Z

I found a problem (microsoft/vcpkg#2406) in new Boost port.
~~We need to wait for fixed.~~ Fixed microsoft/vcpkg#2409

SergioRAgostinho · 2017-12-20T07:57:47Z

UnaNancyOwen · 2017-12-21T15:39:21Z

I will retry to create 3rdParty cache and running tests.

SergioRAgostinho · 2017-12-21T22:44:42Z

Seems like it's time to disable the failing tests :)

UnaNancyOwen · 2017-12-22T13:55:28Z

Currently, These tests have failed.

The following tests FAILED:
	 13 - common_eigen (Failed)
	 23 - feature_rift_estimation (Failed)
	 25 - feature_cppf_estimation (Failed)
	 27 - feature_pfh_estimation (Failed)
	 50 - filters_sampling (Failed)
	 68 - io_grabbers (Failed)
	 81 - registration_api (Failed)

How to disable these tests?
Disable these tests by comment out?

#PCL_ADD_TEST(common_eigen test_eigen FILES test_eigen.cpp LINK_WITH pcl_gtest pcl_common)

Or, Disable these tests by conditional branch?

if(NOT MSVC)
  PCL_ADD_TEST(common_eigen test_eigen FILES test_eigen.cpp LINK_WITH pcl_gtest pcl_common)
endif()

SergioRAgostinho · 2017-12-22T17:35:06Z

More like

…

-DBUILD_global_tests_features=OFF . .. Basically like we used to have on Travis before this recent PR merging everything together.

Sent from my Phone

On 22 Dec 2017, at 13:55, Tsukasa Sugiura ***@***.***> wrote: Currently, These tests have failed. The following tests FAILED: 13 - common_eigen (Failed) 23 - feature_rift_estimation (Failed) 25 - feature_cppf_estimation (Failed) 27 - feature_pfh_estimation (Failed) 50 - filters_sampling (Failed) 68 - io_grabbers (Failed) 81 - registration_api (Failed) How to disable these tests? Would you like to disable these tests by commentout? #PCL_ADD_TEST(common_eigen test_eigen FILES test_eigen.cpp LINK_WITH pcl_gtest pcl_common) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

UnaNancyOwen · 2017-12-23T03:59:49Z

Currently, Vcpkg build failed. microsoft/vcpkg#2427
~~We need to wait for fixed again. :(~~ Fixed

UnaNancyOwen · 2017-12-24T09:57:01Z

Tests was exit without timeout and complete successfully! 🎉
@SergioRAgostinho @taketwo Please review it.

SergioRAgostinho

LGTM. You're gonna need to squash some of these commits. These are the commits which are particularly relevant to be kept isolated:

15b515b
e5103a1 and 43a5193 to be squashed into a single one
The rest can all be squashed into a third commit enabling tests on windows.

Should we freeze vcpkg to the current commit, to prevent upstream breakage down the road?

SergioRAgostinho · 2017-12-24T15:32:19Z

By the way. Why did test_2d started failing now? Is it somehow related to 05a0e95 ? It can be fixed by adding the io dependency on the test_2d target.

Enable Global Tests on Windows CI.

Ninja build system doesn't use CMAKE_*_OUTPUT_DIRECTORY_${CONFIG} that setting the output directory for each build configure.

Add 1.65.1 and 1.66.0

UnaNancyOwen · 2017-12-24T17:02:03Z

Should we freeze vcpkg to the current commit, to prevent upstream breakage down the road?

It will not be installed when cached. And, I think it will be fixed quickly even if there is a time when vcpkg couldn't be built. (#2137 (comment) is unusual case.)
Therefore, I think that it is unnecessary.

By the way. Why did test_2d started failing now? Is it somehow related to 05a0e95 ? It can be fixed by adding the io dependency on the test_2d target.

I tried test_2d with/without that commit, but both case also failed.
It succeed on x64, but failed on x86.

taketwo · 2017-12-25T11:31:06Z

BTW, how did you come up with the list of boost libraries to be installed? These are different from what Travis build needs.

UnaNancyOwen · 2017-12-25T13:43:22Z

This part is the modules that PCL specifies in BOOST_REQUIRED_MODULES(pcl_find_boost.cmake#L39-L45).
In Addition, I added the other modules that was required when tried to built on my local environment.
Should I specify more strictly?

boost-system
boost-filesystem
boost-thread
boost-date-time
boost-iostreams
boost-chrono

SergioRAgostinho reviewed Dec 10, 2017

View reviewed changes

SergioRAgostinho added the status: needs upstream fix label Dec 11, 2017

UnaNancyOwen mentioned this pull request Dec 13, 2017

Configurable time limit appveyor/ci#517

Closed

UnaNancyOwen force-pushed the fix_appveyor branch 2 times, most recently from 7616af4 to 7c53cf9 Compare December 17, 2017 12:20

UnaNancyOwen added status: needs decision needs: code review Specify why not closed/merged yet labels Dec 18, 2017

SergioRAgostinho reviewed Dec 19, 2017

View reviewed changes

SergioRAgostinho added needs: author reply Specify why not closed/merged yet and removed needs: code review Specify why not closed/merged yet status: needs upstream fix status: needs decision labels Dec 19, 2017

SergioRAgostinho added needs: more work Specify why not closed/merged yet status: needs upstream fix and removed needs: author reply Specify why not closed/merged yet labels Dec 20, 2017

SergioRAgostinho removed the status: needs upstream fix label Dec 21, 2017

UnaNancyOwen force-pushed the fix_appveyor branch from 340309f to b01703e Compare December 23, 2017 03:29

SergioRAgostinho approved these changes Dec 24, 2017

View reviewed changes

SergioRAgostinho added status: needs decision needs: author reply Specify why not closed/merged yet and removed needs: more work Specify why not closed/merged yet labels Dec 24, 2017

SergioRAgostinho requested a review from taketwo December 24, 2017 15:29

UnaNancyOwen force-pushed the fix_appveyor branch from eacd233 to 17a0bf2 Compare December 24, 2017 15:38

UnaNancyOwen added 3 commits December 25, 2017 00:38

Enable Global Tests on Windows CI

6de8a71

Enable Global Tests on Windows CI.

Fix Output Directories for Ninja

e29a74c

Ninja build system doesn't use CMAKE_*_OUTPUT_DIRECTORY_${CONFIG} that setting the output directory for each build configure.

Update Boost_ADDITIONAL_VERSIONS

e1ffbc4

Add 1.65.1 and 1.66.0

UnaNancyOwen force-pushed the fix_appveyor branch from 17a0bf2 to e1ffbc4 Compare December 24, 2017 17:03

taketwo approved these changes Dec 25, 2017

View reviewed changes

SergioRAgostinho removed status: needs decision needs: author reply Specify why not closed/merged yet labels Dec 26, 2017

SergioRAgostinho merged commit 26ed605 into PointCloudLibrary:master Dec 26, 2017

SergioRAgostinho mentioned this pull request Aug 6, 2018

Change Log automation #2385

Closed

SergioRAgostinho mentioned this pull request Aug 25, 2018

Change Log generation tool. Automates change log generation. #2396

Merged

SergioRAgostinho added platform: windows module: ci changelog: new feature Meta-information for changelog generation labels Aug 26, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable Global Tests on Windows CI #2137

Enable Global Tests on Windows CI #2137

UnaNancyOwen commented Dec 10, 2017

UnaNancyOwen commented Dec 10, 2017 •

edited

Loading

SergioRAgostinho Dec 10, 2017

UnaNancyOwen Dec 18, 2017

SergioRAgostinho commented Dec 13, 2017

UnaNancyOwen commented Dec 14, 2017 •

edited

Loading

SergioRAgostinho commented Dec 14, 2017 via email

UnaNancyOwen commented Dec 18, 2017 •

edited

Loading

UnaNancyOwen commented Dec 18, 2017 •

edited

Loading

UnaNancyOwen commented Dec 18, 2017

SergioRAgostinho left a comment

SergioRAgostinho Dec 19, 2017

SergioRAgostinho Dec 19, 2017

UnaNancyOwen commented Dec 19, 2017 •

edited

Loading

UnaNancyOwen commented Dec 20, 2017

UnaNancyOwen commented Dec 20, 2017 •

edited

Loading

SergioRAgostinho commented Dec 20, 2017

UnaNancyOwen commented Dec 21, 2017

SergioRAgostinho commented Dec 21, 2017

UnaNancyOwen commented Dec 22, 2017 •

edited

Loading

SergioRAgostinho commented Dec 22, 2017 via email

UnaNancyOwen commented Dec 23, 2017 •

edited

Loading

UnaNancyOwen commented Dec 24, 2017 •

edited

Loading

SergioRAgostinho left a comment •

edited

Loading

SergioRAgostinho commented Dec 24, 2017

UnaNancyOwen commented Dec 24, 2017 •

edited

Loading

taketwo commented Dec 25, 2017

UnaNancyOwen commented Dec 25, 2017

Enable Global Tests on Windows CI #2137

Enable Global Tests on Windows CI #2137

Conversation

UnaNancyOwen commented Dec 10, 2017

UnaNancyOwen commented Dec 10, 2017 • edited Loading

SergioRAgostinho Dec 10, 2017

Choose a reason for hiding this comment

UnaNancyOwen Dec 18, 2017

Choose a reason for hiding this comment

SergioRAgostinho commented Dec 13, 2017

UnaNancyOwen commented Dec 14, 2017 • edited Loading

SergioRAgostinho commented Dec 14, 2017 via email

UnaNancyOwen commented Dec 18, 2017 • edited Loading

UnaNancyOwen commented Dec 18, 2017 • edited Loading

UnaNancyOwen commented Dec 18, 2017

SergioRAgostinho left a comment

Choose a reason for hiding this comment

SergioRAgostinho Dec 19, 2017

Choose a reason for hiding this comment

SergioRAgostinho Dec 19, 2017

Choose a reason for hiding this comment

UnaNancyOwen commented Dec 19, 2017 • edited Loading

UnaNancyOwen commented Dec 20, 2017

UnaNancyOwen commented Dec 20, 2017 • edited Loading

SergioRAgostinho commented Dec 20, 2017

UnaNancyOwen commented Dec 21, 2017

SergioRAgostinho commented Dec 21, 2017

UnaNancyOwen commented Dec 22, 2017 • edited Loading

SergioRAgostinho commented Dec 22, 2017 via email

UnaNancyOwen commented Dec 23, 2017 • edited Loading

UnaNancyOwen commented Dec 24, 2017 • edited Loading

SergioRAgostinho left a comment • edited Loading

Choose a reason for hiding this comment

SergioRAgostinho commented Dec 24, 2017

UnaNancyOwen commented Dec 24, 2017 • edited Loading

taketwo commented Dec 25, 2017

UnaNancyOwen commented Dec 25, 2017

UnaNancyOwen commented Dec 10, 2017 •

edited

Loading

UnaNancyOwen commented Dec 14, 2017 •

edited

Loading

UnaNancyOwen commented Dec 18, 2017 •

edited

Loading

UnaNancyOwen commented Dec 18, 2017 •

edited

Loading

UnaNancyOwen commented Dec 19, 2017 •

edited

Loading

UnaNancyOwen commented Dec 20, 2017 •

edited

Loading

UnaNancyOwen commented Dec 22, 2017 •

edited

Loading

UnaNancyOwen commented Dec 23, 2017 •

edited

Loading

UnaNancyOwen commented Dec 24, 2017 •

edited

Loading

SergioRAgostinho left a comment •

edited

Loading

UnaNancyOwen commented Dec 24, 2017 •

edited

Loading